Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump 3.js to 0.58.9 and voxel-view to repository #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrisekelley
Copy link

The three.js bump may cause problems for others, but works fine for me. Also, voxel-view has not yet incremented to catch up to your patch to enable three.js R57/58 compat, so I've linked to the repository directly.

@chrisekelley
Copy link
Author

Max - Please hold off on this request. It works fine in voxel-client, but I just linked to voxel-server and it's blowing up. Sorry about that...I'll dig a little deeper on this. Here's the error:

/Users/chrisk/source/voxel-engine/node_modules/voxel-texture/index.js:25
  this.canvas = document.createElement('canvas');
                ^
ReferenceError: document is not defined
    at new Texture (/Users/chrisk/source/voxel-engine/node_modules/voxel-texture/index.js:25:17)
    at Texture (/Users/chrisk/source/voxel-engine/node_modules/voxel-texture/index.js:5:42)
    at new Game (/Users/chrisk/source/voxel-engine/index.js:90:20)
    at Game (/Users/chrisk/source/voxel-engine/index.js:29:39)
    at module.exports (/Users/chrisk/source/voxel-server/index.js:37:14)

Blows up in server otherwise.
@chrisekelley
Copy link
Author

Sorted out that issue - voxel-texture has been updated and tries to access document when creating a new canvas. Added a test for browser in the last commit.

deathcap added a commit to deathcap/voxel-engine that referenced this pull request Nov 30, 2013
@deathcap
Copy link
Collaborator

deathcap commented Apr 5, 2014

I have updated three.js to 0.58.9 on my branch https://github.com/deathcap/voxel-engine and it works fine, however it would need to be pulled out from other unrelated changes into an updated PR. But the three.s NPM module has been updated since then: https://www.npmjs.org/package/three - Version 0.66.2 last updated a month ago (but not without incompatibilities: max-mapper/minecraft-skin#5 - another reason for voxel/issues#4 ndarray/gl-now integration)

@deathcap
Copy link
Collaborator

deathcap commented Apr 6, 2014

npm view three versions shows all the published versions of https://www.npmjs.org/package/three:

0.54.0-dev, 0.54.0, 0.54.1-dev, 0.54.2-dev, 0.54.3-dev, 0.54.4-dev, 0.54.5-dev, 0.54.6-dev, 0.54.7-dev, 0.54.8-dev, 0.54.9-dev, 0.54.10-dev, 0.54.11-dev, 0.54.12-dev, 0.55.0, 0.56.0, 0.56.1, 0.56.2, 0.56.3, 0.56.4, 0.56.7, 0.58.1, 0.58.2, 0.58.3, 0.58.4, 0.58.5, 0.58.6, 0.58.7, 0.58.8, 0.58.9, 0.58.10, 0.66.0, 0.66.1, 0.66.2

incompatibilities: https://github.com/mrdoob/three.js/wiki/Migration

deathcap added a commit to deathcap/voxel-engine that referenced this pull request Apr 7, 2014
Required update to voxel-mesh:
deathcap/voxel-mesh@b170a0f Replace Face4 with two Face3s, for three.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants