Implement synchronous horizontal scroll #111
Conversation
zhmylove
force-pushed
the
dev/zhmylove/syncXScroll
branch
from
4493228 to
25f1a56
Compare
| @@ -138,6 +138,9 @@ class GlobalOptions( | |||
| val isSwapKeys: Boolean | |||
| get() = getBooleanProperty(SWAP_KEYS, false) | |||
|
|
|||
| val isSyncXScroll: Boolean | |||
There was a problem hiding this comment.
@zhmylove here you use old Orion's approach to work with properties, it doesn't reflect changes in setting until application restart. Please take a look on DRAW_PAGE_BORDER property below, it defines OBSERVABLE property that listens all changes in settings
There was a problem hiding this comment.
Sure, I'll update this part of code soon
| activePages.forEach { | ||
| if (it.isOnScreen) { | ||
| if (first) |
There was a problem hiding this comment.
Change in doScrollAndDoRendering is clear, but this one is not. Could you please elaborate it?
There was a problem hiding this comment.
I've noticed that orion-viewer does something like prefetch of the pages: it loads around 3 extra pages to the direction of scrolling and changes in doScrollAndDoRendering properly sync their X-position.
The problem was with other pages being loaded during scrolling. I failed setting their X-position in uploadPrevPage and uploadNextPage, nor inside addPageInPosition — those functions just ignored it and new pages (4+ pages below) got improper position. So the only solution I came across is to synchronize X-position for all the pages being rendered in renderVisiblePages
Addresses #102
Implemented new behaviour parameter: syncXScroll which is disabled by default.
When active, it synchronizes horizontal position of all active pages