For OpenLineBelow, add newline to the end of the line of the current … #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.
…selection, instead of the line below the selection, for a more consistent history
JasonBrownDeveloper
force-pushed
the
OpenLineBelow_History
branch
from
37cd8f2 to
68e1a8a
Compare
|
I think this is a good change but I dont quite understand what the last commit is for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OpenLineBelow, add newline to the end of the line of the current selection, instead of the line below the selection, for a more consistent history
Given the following buffer:
Pressing the
okey on (zero indexed) line one, results in the followinghistory:1 1561872 - +2.0|\n
+2.0|Line Two
After the patch, pressing the
okey, the history would look like the following, which would match ifiand<ret>had been pressed on line one.1 1561872 - +1.0|\n
+2.0|Line Two