Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework PX4 airspeed cal due to parameter name/functionality changes #11425

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Rework PX4 airspeed cal due to parameter name/functionality changes #11425

merged 1 commit into from
Jun 11, 2024

Conversation

DonLakeFlyer
Copy link
Contributor

Fix #11252

sfuhrer
sfuhrer reviewed May 23, 2024
View reviewed changes
Copy link

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simplify it and only use SYS_HAS_NUM_ASPD, and enforce the calibration whenever that one is >0.
FW_USE_AIRSPD doesn't need to be checked.

@DonLakeFlyer
Copy link
Contributor Author

I would simplify it and only use SYS_HAS_NUM_ASPD, and enforce the calibration whenever that one is >0.
FW_USE_AIRSPD doesn't need to be checked.

Yup, makes sense

@DonLakeFlyer DonLakeFlyer merged commit da57eee into master Jun 11, 2024
9 checks passed
@DonLakeFlyer DonLakeFlyer deleted the PX4AirspeedCal branch June 11, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfuhrer sfuhrer sfuhrer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The latest QGroundControl and the latest PX4 firmware parameters do not match.
2 participants
@DonLakeFlyer @sfuhrer