Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix to "NAR: Compile failed: Output filename conflict" #178

Closed
wants to merge 2 commits into from
Closed

A fix to "NAR: Compile failed: Output filename conflict" #178

wants to merge 2 commits into from

Conversation

Oneplus
Copy link
Contributor

@Oneplus Oneplus commented Jun 11, 2015

I generally follow #141 to insert a hash(absoluteSourceFilePath) between the object file basename and its extension. I found it quite difficult to mirror the folder structure of the source file into the object file (like discussed in #162 ), because the compile interface in src/main/java/com/github/maven_nar/cpptasks/compiler/AbstractCompiler.java make the output file invisiable to commandlinecompiler.

What #141 seemed to miss is that c++ compiler should compile one source into one object file by one command. But the original code seems to feed several sources to one command and it makes -o to several objects invalid.

It's a quick and dirty solution to the conflict problem however may works.

@buildhive
Copy link

NAR plugin for Maven » nar-maven-plugin #340 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@Oneplus Oneplus closed this Jun 11, 2015
@Oneplus Oneplus reopened this Jun 11, 2015
@Oneplus
Copy link
Contributor Author

Oneplus commented Jun 11, 2015

Found it fails it0018-fortran. Could anyone advise on the possible reason?

@buildhive
Copy link

NAR plugin for Maven » nar-maven-plugin #341 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

NAR plugin for Maven » nar-maven-plugin #342 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@Oneplus Oneplus closed this Jun 12, 2015
@ctrueden
Copy link
Contributor

Presumably this is superseded by #179 now?

@Oneplus
Copy link
Contributor Author

Oneplus commented Jun 12, 2015

@ctrueden Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants