Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bloom_filter_bitwise test (issue #12) #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edenzik
Copy link

@edenzik edenzik commented Oct 26, 2016

In a bitwise bloom filter test, the test passed with an additional hash function at the first level.

In a bitwise bloom filter test, the test passed with an additional hash function at the first level.
@edenzik edenzik mentioned this pull request Oct 26, 2016
@mavam
Copy link
Owner

mavam commented Oct 26, 2016

Thanks for the patch. To me, it looks like the errors of #12 concern the stable Bloom filter, not the bitwise. Were you also getting errors for the stable Bloom filter?

But in any case, there appears to be some non-determinism in the test suite, presumably due to standard library and architecture (32 vs 64 bit) differences.

What I'd really like to move towards is a different architecture with the hashing all together, as I've started in the topic branch N3980. This form of hashing already works in another project of mine and would have just to be ported over in this project. But as I'm lacking the cycles to do so, any help from the community would be much appreciated. (I'm happy to provide feedback/help throughout the process.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants