Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize babel template substitutions #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vjpr
Copy link

@vjpr vjpr commented Nov 18, 2018

What

#6 (comment)

Why

#6

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
    • There seem to be a ton of missing semicolon warnings.

@vjpr vjpr mentioned this pull request Nov 18, 2018
@codecov-io
Copy link

codecov-io commented Nov 18, 2018

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         157    157           
  Branches       23     23           
=====================================
  Hits          157    157
Impacted Files Coverage Δ
src/scope/templates/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435efe4...97c304a. Read the comment docs.

@freewind
Copy link

Someone will approve this PR?

Copy link

@capaj capaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. Please merge this and publish if you can

@capaj
Copy link

capaj commented Mar 13, 2021

TIL I can review code in any public repo on github. Sad thing is, it won't help one bit in getting this merged.

@capaj
Copy link

capaj commented Mar 13, 2021

Anyway for people who want to use the fork, I have changed the prepublish script to prepare on my fork of @vjpr's one so if you want to use this macro with latest babel just install it like this: npm i capaj/babel-plugin-console -D
This will pull the package straight from github and build it right after install.
Confirmed working in vite without any additional plugins:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants