Skip to content

Commit

Permalink
Merge pull request #52 from matthodan/fix-rubocop-offenses-2
Browse files Browse the repository at this point in the history
Fix rubocop offenses (again)
  • Loading branch information
janosrusiczki authored Jun 27, 2019
2 parents fa0be3a + 249784f commit ba7776d
Show file tree
Hide file tree
Showing 39 changed files with 79 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
AllCops:
TargetRubyVersion: 2.3

# Do not count block length in spec files
Metrics/BlockLength:
ExcludedMethods: ['describe', 'it', 'context']

MethodLength:
Max: 15

1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
language: ruby

rvm:
- 2.2
- 2.3
- 2.4
- 2.5
Expand Down
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

source 'http://rubygems.org'

group :test do
Expand Down
2 changes: 2 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'rake'
require 'rake/testtask'

Expand Down
4 changes: 3 additions & 1 deletion jekyll_asset_pipeline.gemspec
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require File.expand_path('lib/jekyll_asset_pipeline/version', __dir__)

Gem::Specification.new do |s|
Expand All @@ -22,7 +24,7 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/matthodan/jekyll-asset-pipeline'
s.license = 'MIT'

s.required_ruby_version = '>= 2.2.0'
s.required_ruby_version = '>= 2.3.0'
s.rubygems_version = '2.2.2'

# Runtime dependencies
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

# Stdlib dependencies
require 'digest/md5'
require 'fileutils'
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/asset.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Holds an asset (file)
class Asset
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/compressor.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Base class for asset compressors
# See https://github.com/matthodan/jekyll-asset-pipeline#asset-compression
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/converter.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Base class for asset converters
# See https://github.com/matthodan/jekyll-asset-pipeline#asset-preprocessing
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/extensions/jekyll/site.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module Jekyll
# Contains overrides for the needed Jekyll:Site methods
# The actual code is in JekyllAssetPipeline::JekyllSiteExtensions
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Contains overrides for the needed Jekyll:Site methods
# Included in Jekyll::Site
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/extensions/liquid/asset_tag.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# This is a Liquid tag block extension
# See documentation here:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

# This comment is needed, otherwise Rubocop complains because of the
# register_tag below and a verbose comment is better than a :nodoc: :)
module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

# This comment is needed, otherwise Rubocop complains because of the
# register_tag below and a verbose comment is better than a :nodoc: :)
module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Helper module used by JekyllAssetPipeline::AssetTag as well as
# classed derived from it (Liquid tag block extensions)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Allows classes that extend this to return an array of their subclasses
module SubclassTracking
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/pipeline.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# The pipeline itself, the run method is where it all happens
# rubocop:disable ClassLength
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/template.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Base class for the tag templates
# See https://github.com/matthodan/jekyll-asset-pipeline#templates
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/templates/css_tag_template.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Default output for CSS assets
class CssTagTemplate < JekyllAssetPipeline::Template
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Default output for JavaScript assets
class JavaScriptTagTemplate < JekyllAssetPipeline::Template
Expand Down
2 changes: 2 additions & 0 deletions lib/jekyll_asset_pipeline/templates/template_helper.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
# Contains helper methods used by the tag template classes
module TemplateHelper
Expand Down
4 changes: 3 additions & 1 deletion lib/jekyll_asset_pipeline/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
VERSION = '0.6.0'.freeze
VERSION = '0.6.0'
end
2 changes: 2 additions & 0 deletions spec/helper.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'coveralls'
Coveralls.wear!

Expand Down
2 changes: 2 additions & 0 deletions spec/helpers/extensions/ruby/module.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

# Allow us to test if a module extends another module/class
#
# For example:
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/asset_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/compressor_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/converter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/extensions/jekyll/site_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/integration_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

describe 'Integration' do
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/pipeline_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

# rubocop:disable ModuleLength
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/template_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

# rubocop:disable ModuleLength
Expand Down
2 changes: 2 additions & 0 deletions spec/jekyll_asset_pipeline/version_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require './spec/helper'

module JekyllAssetPipeline
Expand Down
2 changes: 2 additions & 0 deletions spec/resources/source/_plugins/jekyll_asset_pipeline.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module JekyllAssetPipeline
class TestConverter < JekyllAssetPipeline::Converter
def self.filetype
Expand Down

0 comments on commit ba7776d

Please sign in to comment.