Add support for generics on component portmapping & add Natural and Positive types #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
reviewed
Nov 11, 2021
There was a problem hiding this comment.
I left some generic comments and questions. I think the best way forward is to merge this with approval from @matthijsr and @johanpel, because they know a lot more about the details and goals of both this PR and the code it targets.
Comment on lines
+113
to
+114
| /// Natural integer as defined by VHDL. | ||
| pub type Natural = NonNegative; |
There was a problem hiding this comment.
Maybe we should move this type def to the vhdl generator module. What do you think?
Comment on lines
+169
to
+180
| if let ObjectType::Natural = typ { | ||
| Ok(()) | ||
| } | ||
| // Positive can be assigned to natural but not the other way around | ||
| else if let ObjectType::Positive = typ { | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::InvalidTarget(format!( | ||
| "Cannot assign {} to Natural", | ||
| typ | ||
| ))) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let ObjectType::Natural = typ { | |
| Ok(()) | |
| } | |
| // Positive can be assigned to natural but not the other way around | |
| else if let ObjectType::Positive = typ { | |
| Ok(()) | |
| } else { | |
| Err(Error::InvalidTarget(format!( | |
| "Cannot assign {} to Natural", | |
| typ | |
| ))) | |
| } | |
| matches!(typ, ObjectType::Natural | ObjectType::Positive) | |
| .then(|| ()) | |
| .ok_or_else(|| Error::InvalidTarget(format!("Cannot assign {} to Positive", typ))); |
| if let ObjectType::Positive = typ { | ||
| Ok(()) | ||
| } else { | ||
| // Natural can not be assigned to positive because positive does not include 0 |
There was a problem hiding this comment.
Maybe we should add this comment to the error message. What do you think?
Co-authored-by: Matthijs Brobbel <[email protected]>
Co-authored-by: Matthijs Brobbel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for generics takes the parameters from a component and adds them to the portmapping as generics.
The Natural and Positive types are only meant to be used for generics because calculating the width of these types has not been implemented.