[MM-62296] Implement race free signaling through DC based lock #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've finally decided to try to eliminate the various race conditions that still affect signaling because the server side does not implement the perfect negotiation pattern.
My previous statement on this topic was not entirely accurate. Even the browser side could still get into an invalid SDP state. It was just more rare, but it was still fairly reproducible when dealing with more than a single audio track.
Anyhow, to get rid of all of this, we implement a synchronization mechanism (lock) through our data channel.
Related PR
mattermost/calls-common#45
Ticket Link
https://mattermost.atlassian.net/browse/MM-62296