-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biometric prompt, Jailbreak / Root detection and screenshot prevention #8645
Open
enahum
wants to merge
17
commits into
main
Choose a base branch
from
securityManager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,811
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig type definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
release-note
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a security manager class to control the new security features introduced on a per-server level in addition to the app level managed by EMM providers.
This features are:
These features will work on a per-server basis only if not set with a EMM provider.
In order to prevent screenshots on iOS (the way it works is detailed in the library PR) we are adding a
nativeID
to views on screens and components whereshielded
means that it should be protected andskip.shielded
means that we won't be protecting this view (for screens like the ones in the login flow)Related PR's:
Server: mattermost/mattermost#30411
Library: mattermost/react-native-emm#18
Ticket Link
https://mattermost.atlassian.net/browse/MM-63362
https://mattermost.atlassian.net/browse/MM-63363
https://mattermost.atlassian.net/browse/MM-63364
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on:
Android 14 & 15 emulators
iPhone 16 Pro and iPad 13 Pro iOS 18
Screenshots
Will add if requested
Release Note