[GH-8636] Prevent Cross-fade out keyboard to fill up view #8638
Conversation
|
Hello @anlerandy, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
rahimrahman
requested review from
Copilot,
enahum and
a team
and removed request for
a team
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Hi @anlerandy , thanks for the PR!! can you sign the CLA? otherwise we can't accept any changes. If you have already done so, let us know to check again or see if there is any problem with the automation. |
|
Hi @Willyfrog, I do have a problem with CLA. I've used |
|
I think I know what's going on, I'll need to ping some people in the company but this week there is a company wide event and will take some time. |
|
@anlerandy hopefully everything is fixed as of now, but it is likely your signature was missing, can you sing again the CLA? you'll find the form at http://www.mattermost.org/mattermost-contributor-agreement/ |
|
Thanks, @Willyfrog! |
app/context/extra_keyboard/index.tsx
Outdated
| }; | ||
| }, [context, insets.bottom, offset]); | ||
| }, [context, insets.bottom, offset, isNativeKeyOpen]); |
There was a problem hiding this comment.
shouldn't keyb or keyb.state be a dependency?
There was a problem hiding this comment.
While testing, adding it to dependencies didn't change much things, at least not anything related to this PR's fix.
So I decided to leave code as close as it was.
|
Thanks, @enahum, for pointing out the update. It worked perfectly with just the update. Could you take another look? |
enahum
added
2: Dev Review
Summary
Prevent keyboard avoiding space to fill up the view due to
useAnimatedKeyboardincorrect value.Both state & height returned by
useAnimatedKeyboardget corrupted after keyboard close if "Cross-fade transitions" is active - Height is approximately equal to view height ; State is put back to "OPEN".Also, bug can occur using external keyboard ; Keyboard will open briefly before closing.
Ticket Link
#8636
Device Information
This PR was tested on:
Release Note