MM-62533: Improvements for ExternalDBSettings #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We bump the postgres version to 14.9 as that is the version after which "write forwarding" is available on a Global Aurora Cluster. - We also add the ClusterIdentifier for ExternalDBSettings because we need to attach the DB security group to the DB cluster like we do for a restored DB backup. https://mattermost.atlassian.net/browse/MM-62533
streamer45
approved these changes
Jan 14, 2025
Comment on lines
+162
to
+167
| var identifier string | ||
| if t.config.TerraformDBSettings.ClusterIdentifier != "" { | ||
| identifier = t.config.TerraformDBSettings.ClusterIdentifier | ||
| } else { | ||
| identifier = t.config.ExternalDBSettings.ClusterIdentifier | ||
| } |
There was a problem hiding this comment.
This is where I'd love it if Golang could implement some syntactic sugar.
agarciamontoro
approved these changes
Jan 14, 2025
Correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after which "write forwarding" is available on a Global Aurora
Cluster.
because we need to attach the DB security group to the DB cluster
like we do for a restored DB backup.
https://mattermost.atlassian.net/browse/MM-62533