MM-61147: CentOS/RHEL experimental support on feature branch #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Pyroscope v1 Add support for goroutine and block profiles * Unify service name for targets * Update test
|
@fmartingr, do you want us to take a look already? Or should we wait? |
|
@agarciamontoro I put you folks as reviewers to quickly check if I missed something ,your review here is not mandatory since we are already using it. There will be a new PR when I properly implement this in the load-test upstream. |
|
@fmartingr, got it, thanks! |
|
I'm removing myself as a reviewer from this PR, but I'm still subscribed to it, so I'll be notified of any comment. Please add me back as soon as needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWSAMIUserto define the default user for the defined AMI.aws_ami_userterraform variableubuntuuser configurable around the code, using the setting from the deployer configuration.Changes are being tested under CentOS Stream 9. RHEL is not being tested ATM.