Acknowledge websocket POSTED events when they should be #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarciamontoro
requested changes
Apr 5, 2024
| @@ -36,6 +36,12 @@ func (c *SimulController) wsEventHandler(wg *sync.WaitGroup) { | |||
| break | |||
| } | |||
|
|
|||
| if ack, ok := ev.GetData()["should_ack"]; ok && ack.(bool) { | |||
There was a problem hiding this comment.
Double-checking: What should we do if there's no "should_ack" key in the event data? Just skip?
There was a problem hiding this comment.
Correct. we only want to actually send the ACK back if the posted event has this flag, if not we shouldn't do anything.
| @@ -36,6 +36,12 @@ func (c *SimulController) wsEventHandler(wg *sync.WaitGroup) { | |||
| break | |||
| } | |||
|
|
|||
| if ack, ok := ev.GetData()["should_ack"]; ok && ack.(bool) { | |||
| go func() { | |||
| c.user.PostedAck(post.Id, "success", "", "") | |||
There was a problem hiding this comment.
We should log the potential error returned by PostedAck
There was a problem hiding this comment.
Good call. Do I need to just pass the error to the c.status channel if there is one?
streamer45
reviewed
Apr 5, 2024
streamer45
approved these changes
Apr 8, 2024
agarciamontoro
approved these changes
Apr 11, 2024
fmartingr
pushed a commit
that referenced
this pull request
Apr 18, 2024
* WIP * Use a goroutine for the ACK * Only ACK other users posts * Only ack if the prop is true * Change the ack name * Use non-blocking call to buffered channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding to the load tester the changes needed to test this PR.
Marking as Draft for now since I think we might want to revisit how we want to queue the ACKs to send back.
Ticket Link
https://mattermost.atlassian.net/browse/MM-57006
https://mattermost.atlassian.net/browse/MM-57067