Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.tar to the .gitignore #721

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add *.tar to the .gitignore #721

merged 1 commit into from
Apr 2, 2024

Conversation

devinbinnie
Copy link
Member

Summary

Since the collect command drops a *.tar file into the main directory you're running the load tester from, it makes sense to ignore those for the Git repository, so they aren't accidentally committed/sitting in your unstaged changes.

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Apr 1, 2024
Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 2, 2024
@devinbinnie devinbinnie merged commit 00f046a into master Apr 2, 2024
1 check passed
@devinbinnie devinbinnie deleted the add_tar_to_gitignore branch April 2, 2024 21:29
fmartingr pushed a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants