Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenID authentication support using a KeyCloak server #720
Add OpenID authentication support using a KeyCloak server #720
Changes from 61 commits
ff6685e
3b8b843
6f90dcc
919149c
a861efe
7c43c23
b3e5fda
8217a3d
8cf9d2a
5446c20
56c7df7
343e055
a190c7a
066e964
9b4cee4
b5ac989
0b8b574
babebb7
c8a37f0
5dbf56d
f5ac82f
6e19432
e041458
28c3beb
aadc041
003f979
4a454d2
e556ce6
20dbc81
49c02dc
a611473
5bbd2a6
49605ea
dc4191d
8182e44
eadca08
c7b08b3
2b9526f
c54a0a9
b1de1d2
bdd340e
7a86020
b3f7dae
67d29d4
4024790
49ece26
95ccbe5
791d40c
5011569
4c08af4
4b35f96
50842ad
fec4c6e
9ed759f
25c3ba0
ad1fb66
e9a5945
c9aa2ba
2384ca6
9de8440
7ca520b
19c839a
cba76a8
e9115db
1c83664
12b5487
d812cea
ffc628b
e7a406f
9fccc75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this information to docs/external_auth_providers.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could become a util function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make a note of this but refrain from modifying too much logic until this is merged now that we have this working. I can address the rest of the comments in individual PRs later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it not be "false" by default? The default config is always aimed towards production usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it as
false
because the difference development vs production means. If I use the production option I have to disable some of the features it enables manually (like enforced hostnames, SSL, local cache). I could go that route but in the end we would have the same result but with more work. That is, unless we want to really run it in production mode with all security features enforced as they should be.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me why we need the agents to update their hosts file with the SiteURL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've had a discussion here: https://community.mattermost.com/core/pl/1944im15z3f1pn9thb647kdi5y. I am 0/5 as long as it doesn't break permalinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an straightforward way for me to check that permalinks are working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the agents host will not break permalinks: the problem was with the app nodes trying to retrieve the data from the permalink. As long as we don't touch that, permalinks will keep working.