MM-57261: Use a valid database engine version for MySQL #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the describe-db-engine-versions subcommand of the aws cli, the only patch version for 3.05 is 3.05.2, but we're upgrading to the newer 3.06 nonetheless: > aws --profile=mm-loadtest rds describe-db-engine-versions --engine aurora-mysql | jq '.DBEngineVersions[].EngineVersion' "5.7.mysql_aurora.2.07.9" "5.7.mysql_aurora.2.07.10" "5.7.mysql_aurora.2.11.1" "5.7.mysql_aurora.2.11.2" "5.7.mysql_aurora.2.11.3" "5.7.mysql_aurora.2.11.4" "5.7.mysql_aurora.2.11.4" "5.7.mysql_aurora.2.12.0" "5.7.mysql_aurora.2.12.1" "8.0.mysql_aurora.3.01.0" "8.0.mysql_aurora.3.01.1" "8.0.mysql_aurora.3.02.0" "8.0.mysql_aurora.3.02.1" "8.0.mysql_aurora.3.02.2" "8.0.mysql_aurora.3.02.3" "8.0.mysql_aurora.3.03.0" "8.0.mysql_aurora.3.03.1" "8.0.mysql_aurora.3.03.2" "8.0.mysql_aurora.3.03.3" "8.0.mysql_aurora.3.04.0" "8.0.mysql_aurora.3.04.1" "8.0.mysql_aurora.3.04.2" "8.0.mysql_aurora.3.05.2" "8.0.mysql_aurora.3.06.0"
streamer45
reviewed
Mar 14, 2024
| @@ -54,7 +54,7 @@ variable "db_cluster_identifier" { | |||
| variable "db_engine_version" { | |||
| type = map(any) | |||
| default = { | |||
| "aurora-mysql" = "8.0.mysql_aurora.3.05.0" | |||
| "aurora-mysql" = "8.0.mysql_aurora.3.06.0" | |||
There was a problem hiding this comment.
Can we use 3.05.2 instead? The idea was to use the same MySQL patch version as our min supported one which is 8.0.32.
There was a problem hiding this comment.
Ah, of course, hadn't thought of that. Let me change it.
MySQL minimum supported version is 8.0.32
cpoile
approved these changes
Mar 14, 2024
agarciamontoro
added
4: Reviews Complete
|
I'll test this, merge and cherry-pick to |
|
DB correctly created with 3.05.2 version: |
agarciamontoro
added a commit
that referenced
this pull request
Mar 14, 2024
* Use a valid database engine version for MySQL According to the describe-db-engine-versions subcommand of the aws cli, the only patch version for 3.05 is 3.05.2: > aws --profile=mm-loadtest rds describe-db-engine-versions --engine aurora-mysql | jq '.DBEngineVersions[].EngineVersion' "5.7.mysql_aurora.2.07.9" "5.7.mysql_aurora.2.07.10" "5.7.mysql_aurora.2.11.1" "5.7.mysql_aurora.2.11.2" "5.7.mysql_aurora.2.11.3" "5.7.mysql_aurora.2.11.4" "5.7.mysql_aurora.2.11.4" "5.7.mysql_aurora.2.12.0" "5.7.mysql_aurora.2.12.1" "8.0.mysql_aurora.3.01.0" "8.0.mysql_aurora.3.01.1" "8.0.mysql_aurora.3.02.0" "8.0.mysql_aurora.3.02.1" "8.0.mysql_aurora.3.02.2" "8.0.mysql_aurora.3.02.3" "8.0.mysql_aurora.3.03.0" "8.0.mysql_aurora.3.03.1" "8.0.mysql_aurora.3.03.2" "8.0.mysql_aurora.3.03.3" "8.0.mysql_aurora.3.04.0" "8.0.mysql_aurora.3.04.1" "8.0.mysql_aurora.3.04.2" "8.0.mysql_aurora.3.05.2" "8.0.mysql_aurora.3.06.0" * Use 3.05.2 to match our minimum supported version MySQL minimum supported version is 8.0.32
agarciamontoro
added a commit
that referenced
this pull request
Mar 14, 2024
* Use a valid database engine version for MySQL According to the describe-db-engine-versions subcommand of the aws cli, the only patch version for 3.05 is 3.05.2: > aws --profile=mm-loadtest rds describe-db-engine-versions --engine aurora-mysql | jq '.DBEngineVersions[].EngineVersion' "5.7.mysql_aurora.2.07.9" "5.7.mysql_aurora.2.07.10" "5.7.mysql_aurora.2.11.1" "5.7.mysql_aurora.2.11.2" "5.7.mysql_aurora.2.11.3" "5.7.mysql_aurora.2.11.4" "5.7.mysql_aurora.2.11.4" "5.7.mysql_aurora.2.12.0" "5.7.mysql_aurora.2.12.1" "8.0.mysql_aurora.3.01.0" "8.0.mysql_aurora.3.01.1" "8.0.mysql_aurora.3.02.0" "8.0.mysql_aurora.3.02.1" "8.0.mysql_aurora.3.02.2" "8.0.mysql_aurora.3.02.3" "8.0.mysql_aurora.3.03.0" "8.0.mysql_aurora.3.03.1" "8.0.mysql_aurora.3.03.2" "8.0.mysql_aurora.3.03.3" "8.0.mysql_aurora.3.04.0" "8.0.mysql_aurora.3.04.1" "8.0.mysql_aurora.3.04.2" "8.0.mysql_aurora.3.05.2" "8.0.mysql_aurora.3.06.0" * Use 3.05.2 to match our minimum supported version MySQL minimum supported version is 8.0.32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to the
describe-db-engine-versionssubcommand of the aws cli (the source of truth for the valid versions), the only patch version for 3.05 is 3.05.2,but we're upgrading to the newer 3.06 nonetheless:Ticket Link
https://mattermost.atlassian.net/browse/MM-57261