Use PostgreSQL 14 in DB parameter groups

[agarciamontoro]

Summary

I was adding some DB parameters to log slow queries through the TerraformDBSettings.DBParameters setting when I encountered this error:

info  [2024-03-13 16:08:04.732 Z] ╷                              caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │ Error: updating RDS Cluster Instance (agm100m-db-0): InvalidParameterCombination: The parameter group agm100m-db-pg with DBParameterGroupFamily aurora-postgresql12 can't be used for this instance. Use a parameter group with DBParameterGroupFamily aurora-postgresql14. caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │     status code: 400, request id: 86819d3b-384b-4085-8212-09eafaa3e753 caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │                              caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │   with aws_rds_cluster_instance.cluster_instances[0], caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │   on cluster.tf line 313, in resource "aws_rds_cluster_instance" "cluster_instances": caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │  313: resource "aws_rds_cluster_instance" "cluster_instances" { caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] │                              caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.732 Z] ╵                              caller="terraform/engine.go:97"
info  [2024-03-13 16:08:04.740 Z] ╷                              caller="terraform/engine.go:97"

It turns out we forgot to update this line back when we updated to Postgres 14, and I have never used the param group setting since, so the bug kept hidden.

Ticket Link

--

[agarciamontoro]

We should probably write some E2E tests that do a dummy deployment trying to use all config values we have.