MM-52337: Use aws_opensearch_domain #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version, 3.0, did not support aws_opensearch_domain resource, so we bumped it to the latest one. In turn, the latest version, 5.39 does not support aws_subnet_ids, which was replaced with aws_subnets.
This is done running terraform init -upgrade inside the deployment/terraform/assets directory.
The version is now specified in the engine_version field, not in the elasticsearch_version field. This field is now a string instead of a number.
agnivade
approved these changes
Mar 5, 2024
| @@ -2,21 +2,81 @@ | |||
| # Manual edits may be lost in future updates. | |||
There was a problem hiding this comment.
Is this file meant to be checked in?
There was a problem hiding this comment.
You asked this exact same question almost three years ago hahaha
Answering your question: yes. I had the same question you had three years ago (and today), double-checked the docs and yes, they still recommend to check it in.
isacikgoz
approved these changes
Mar 5, 2024
I'm always impressed about the groundwork of the |
agarciamontoro
added
4: Reviews Complete
|
Merging, this has already been successfully tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We decided to use the latest OpenSearch version compatible with ElasticSearch (i.e., those until the latest OSS version of ElasticSearch, v7.10).
This PR addresses this decision, replacing the aws_elasticsearch_domain resource with aws_opensearch_domain. This forced me to upgrade the Terraform's aws provider itself, and some things had to be changed because of that.
This has been tested in a deployment using an
r6g.large.searchinstance withElasticsearch_7.10. It deployed successfully, and a manual index of the 20M posts DB finished in 5 hours.Ticket Link
https://mattermost.atlassian.net/browse/MM-52337