Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #700

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Update dependencies #700

merged 3 commits into from
Mar 1, 2024

Conversation

agarciamontoro
Copy link
Member

Summary

Ran make update-dependencies.

Ticket Link

--

@agarciamontoro agarciamontoro added the 2: Dev Review Requires review by a core committer label Feb 28, 2024
@agarciamontoro
Copy link
Member Author

PR #700, let's celebrate! 🎉

@agarciamontoro
Copy link
Member Author

For some reason, using go 1.19 made golangci-lint fail with this error:

WARN [runner] Can't run linter goanalysis_metalinter: buildir: failed to load package model: could not load export data: no export data for "github.com/prometheus/common/model"
ERRO Running error: 1 error occurred:
	* can't run linter goanalysis_metalinter: buildir: failed to load package model: could not load export data: no export data for "github.com/prometheus/common/model"

I didn't catch this locally because my local version was 1.20. I'm not sure why 1.19 triggered this error, but an update has been pending for a while in any case, so here it is.

Re-requesting review for the new changes.

@@ -20,7 +20,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0
with:
go-version: "1.19.5"
go-version: "1.20.14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the dot release actually needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, to be honest. It was a quick fix so I just copied the same pattern. Let me check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍

@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 1, 2024
@agarciamontoro agarciamontoro merged commit f5f903f into master Mar 1, 2024
1 check passed
@agarciamontoro agarciamontoro deleted the update.deps.feb.28 branch March 1, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants