-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #700
Update dependencies #700
Conversation
PR #700, let's celebrate! 🎉 |
For some reason, using go 1.19 made golangci-lint fail with this error:
I didn't catch this locally because my local version was 1.20. I'm not sure why 1.19 triggered this error, but an update has been pending for a while in any case, so here it is. Re-requesting review for the new changes. |
.github/workflows/ci.yml
Outdated
@@ -20,7 +20,7 @@ jobs: | |||
- name: Setup Go | |||
uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0 | |||
with: | |||
go-version: "1.19.5" | |||
go-version: "1.20.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the dot release actually needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, to be honest. It was a quick fix so I just copied the same pattern. Let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it's not needed: https://github.com/marketplace/actions/setup-go-environment#supported-version-syntax Let's see in practice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works 👍
Summary
Ran
make update-dependencies
.Ticket Link
--