Add note about --prometheus-url in local deployments #698
Conversation
docs/compare.md
Outdated
| @@ -8,6 +8,8 @@ After a load test is complete, a report can be generated and saved to a file whi | |||
| go run ./cmd/ltctl report generate --output=base.out --label=base "2020-06-23 07:23:35" "2020-06-23 07:33:35" | |||
| ``` | |||
|
|
|||
| Note that in the case of a local deployment, you'll need to set the `--prometheus-url ` flag to the URL of the Prometheus server from where the tool will scrape the results. | |||
There was a problem hiding this comment.
this is great, but I think there is a need to add a link that points to how to set this up in order to collect the data in the prometheus server.
There was a problem hiding this comment.
Do you mean about how to set up a Prometheus server?
There was a problem hiding this comment.
Check the latest commit f9b28ab and let me know if that's what you had in mind!
docs/compare.md
Outdated
| @@ -8,6 +8,8 @@ After a load test is complete, a report can be generated and saved to a file whi | |||
| go run ./cmd/ltctl report generate --output=base.out --label=base "2020-06-23 07:23:35" "2020-06-23 07:33:35" | |||
| ``` | |||
|
|
|||
| Note that in the case of a local deployment, you'll need to set the `--prometheus-url ` flag to the URL of the Prometheus server from where the tool will scrape the results. | |||
There was a problem hiding this comment.
Wondering if we can make the tool a bit more intuitive so that one doesn't have to read through so much documentation? Is it possible that running the command without the url throws an error like "please pass --promtheus-url" or "invalid prometheus-url, check if you have set it"?
|
I created a new ticket to fix the underlying problems here: https://mattermost.atlassian.net/browse/MM-56949 For this PR, I added a new comment when retrieving the URL from the Terraform deployment so that users know what's happening. |
Summary
Just a clarification identified in https://community.mattermost.com/core/pl/adw9x3jb43ngbjcknses4cgrth
Ticket Link
--