MM-55630: Generate a new dashboard with enabled coordinator metrics #694
Conversation
Generated only when there is at least one enabled query
config/coordinator.sample.json
Outdated
| "Query": "(sum(rate(mattermost_api_time_count{status_code=~\"5..\"}[1m]))/sum(rate(mattermost_api_time_count[1m])))*100", | ||
| "Threshold": 0.025, | ||
| "MinIntervalSec": 60, | ||
| "Alert": true | ||
| }, | ||
| { | ||
| "Description": "Average client request duration", | ||
| "Legend": "Average duration of all requests as measured from the client side", | ||
| "Legend": "Duration in ms (avg)", |
There was a problem hiding this comment.
You don't even need the unit because it's there in the y axis. But ok to keep this :)
There was a problem hiding this comment.
It's not, right? And it's seconds, actually! I'll fix it now
There was a problem hiding this comment.
That's because you haven't mentioned the unit in the display section. If you set that to time in seconds, then it automatically adjusts to ms when it's too low. It's far better that way.
There was a problem hiding this comment.
Yeah, I thought about that. But then we'd have to add yet another field to the coordinator metrics for users to specify the unit. I'd start with this and we can iterate later if needed.
There was a problem hiding this comment.
Why do you need user input for that? It's always in seconds right?
There was a problem hiding this comment.
This particular query is, but the queries are arbitrary and user-defined. Most of the ones we use now are plain percentages.
There was a problem hiding this comment.
Ahhh that's true. Forgot that you are templating the dashboard. All good then 👍
agarciamontoro
added
4: Reviews Complete
Summary
A new Grafana dashboard is dynamically generated when there is at least one enabled query in the coordinator. I had to add a new optional
Legendfield to the queries configuration so that we can provide a string to use as legend in the panel. The following screenshot shows the generated dashboard with the sample metrics (not very interesting graphs, since it was a dummy test):I didn't add the first panel with the number of connected users as shown in the ticket's screenshot, since that's already in the other dashboard.
Ticket Link
https://mattermost.atlassian.net/browse/MM-55630