MM-52240: Stop/Start DB Cluster after load test #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add the ability to stop/start the DB cluster after a load-test is complete. There is a dedicated command that the users can run any time. Additionally, there is also an automated way to stop the DB after a load test finishes, which is exposed via a flag. Using the flag makes the load test runs synchronously, so it is advised to be used only by advanced users running the command preferably inside an EC2 instance in a screen session. https://mattermost.atlassian.net/browse/MM-52240
agnivade
changed the title
agarciamontoro
requested changes
Jan 31, 2024
| return err | ||
| } | ||
|
|
||
| return t.Sync() |
There was a problem hiding this comment.
I'm ok with the solution here, but I guess there must be a way to do this via Terraform so we can avoid the AWS command + Terraform sync 🤔
Comment on lines
+137
to
+140
| // Sleeping for 5 minutes gives 12 lines an hour. | ||
| // For an avg unbounded test of 4-5 hours, it gives around 50 lines, | ||
| // which should be acceptable. | ||
| time.Sleep(5 * time.Minute) |
There was a problem hiding this comment.
I agree it's acceptable 👍
Yep, we always create a cluster. |
agarciamontoro
requested changes
Jan 31, 2024
Co-authored-by: Alejandro García Montoro <[email protected]>
isacikgoz
approved these changes
Feb 1, 2024
| break | ||
| } | ||
| fmt.Println("Sleeping... ") | ||
| time.Sleep(30 * time.Second) |
There was a problem hiding this comment.
Isn't 30 second too much for the ping interval?
There was a problem hiding this comment.
Not really. These take a long time to stop or start. In the order of ~5 minutes.
agnivade
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the ability to stop/start the DB cluster after a load-test is complete.
There is a dedicated command that the users can run any time. Additionally, there is also an automated way to stop the DB after a load test finishes, which is exposed via a flag.
Using the flag makes the load test runs synchronously, so it is advised to be used only by advanced users running the command preferably inside an EC2 instance in a screen session.
https://mattermost.atlassian.net/browse/MM-52240