Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-54985: bump grafana and pyroscope #689

Merged
merged 1 commit into from
Jan 30, 2024
Merged

MM-54985: bump grafana and pyroscope #689

merged 1 commit into from
Jan 30, 2024

Conversation

agnivade
Copy link
Member

@agnivade agnivade added the 2: Dev Review Requires review by a core committer label Jan 25, 2024
streamer45
streamer45 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, does it work out of the box? No weird dashboard rendering issues like we've seen in the past with major version upgrades?

@agnivade
Copy link
Member Author

From my testing, yes indeed it works out of box.

agarciamontoro
agarciamontoro approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neeeeat, thank you! Did you test pyroscope as well? I was concerned the change to v1.x was a breaking one.

@agnivade
Copy link
Member Author

Yep I tested pyroscope as well. All looked good 👍

@agnivade agnivade added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 30, 2024
@agnivade agnivade merged commit 0a8e28e into master Jan 30, 2024
1 check passed
@agnivade agnivade deleted the bumpPyro branch January 30, 2024 02:39
@agarciamontoro agarciamontoro mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

@agarciamontoro agarciamontoro agarciamontoro approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnivade @streamer45 @agarciamontoro