[MM-61280] disable init data if providing external database (#870)

* fix: disable init data if providing external database

* Update cmd/ltctl/main.go

Co-authored-by: Alejandro García Montoro <[email protected]>

* validate configuration and update docs

* typo

---------

Co-authored-by: Alejandro García Montoro <[email protected]>

cmd/ltctl/main.go

@@ -34,7 +34,7 @@ func RunCreateCmdF(cmd *cobra.Command, args []string) error {
 		return fmt.Errorf("failed to create SSH agent: %w", err)
 	}
 
-	initData := config.DBDumpURI == ""
+	initData := config.DBDumpURI == "" && config.ExternalDBSettings.DataSource == ""
 	if err = t.Create(extAgent, initData); err != nil {
 		return fmt.Errorf("failed to create terraform env: %w", err)
 	}

deployment/config.go

@@ -402,6 +402,10 @@ func (c *Config) IsValid() error {
 		return fmt.Errorf("load-test download url is not in correct format: %q", c.LoadTestDownloadURL)
 	}
 
+	if c.ExternalDBSettings.DataSource != "" && c.DBDumpURI != "" {
+		return fmt.Errorf("both ExternalDBSettings.DataSource and DBDumpURI are set, only one can be set")
+	}
+
 	if err := c.validateElasticSearchConfig(); err != nil {
 		return err
 	}

docs/config/deployer.md

@@ -568,6 +568,10 @@ The file is expected to be gzip compressed.
 This can also point to a local file if prefixed with "file://".
 In such case, the dump file will be uploaded to the app servers.
 
+Loading a dump into a database only work for terraform created databases.
+If you are using an existing database by relying on [`ExternalDBSettings`](#ExternalDBSettings)
+you need to load the dump manually.
+
 ## SiteURL
 
 *string*