[CLD-8628 #2] Add custom status code for installation name/dns conflicts + bonus #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion webhook events
mm-cloud-bot
added
the
release-note-none
nickmisasi
commented
Dec 10, 2024
Comment on lines
+672
to
+680
| // Try to parse the user ID from the request context, so it can be passed along with the webhook event | ||
| actorID := "" | ||
| if value := r.Context().Value(ContextKeyUserID{}); value != nil { | ||
| if str, ok := value.(string); ok && str != "" { | ||
| actorID = str | ||
| } | ||
| } | ||
|
|
||
| err = c.EventProducer.ProduceInstallationStateChangeEvent(installationDTO.Installation, oldState, events.DataField{Key: "actor_id", Value: actorID}) |
There was a problem hiding this comment.
I snuck this in while I was here. This passes the ID of the actor that initiated the deletion request, so that webhook listeners can easily detect who did the deletion. The main use case for this will be the Cloud Plugin. Currently, whenever an installation is deleted for any reason, a message "Cloud isntallation <> has been manually deleted and is now removed from the cloud plugin", which confuses users, as sometimes an automatic cleanup script deletes them. With this change, the Cloud Plugin will be able to tell if it itself made the deletion request, or if it was another system, and adjust the message sent accordingly.
nickmisasi
requested review from
andrleite and
stafot
and removed request for
andrleite
stafot
approved these changes
Dec 18, 2024
nickmisasi
added
the
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability for the provisioner to return a custom
409(StatusConflict) status code when the requested installation name, or DNS is already in use on creation. This will allow us to be more communicative to users of the Cloud plugin when they rapidly attempt to delete and recreate an installation within a few minutes of each other, after we turn on the 24h deletion pending window.Ticket Link
https://mattermost.atlassian.net/browse/CLD-8628
Release Note