QOL: Add ClusterIDs array to InstallationDTO object #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
andrleite
approved these changes
Dec 10, 2024
nickmisasi
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds ClusterID to the InstallationDTO object. Currently, when given an installation's DNS, it takes 2 CLI commands to figure out the cluster - first, you must run
cloud installation list --dns <dns>to get the installation ID, from there you can get the Cluster ID (there are various other routes you can take, but the list step happens in each). This PR makes it so that the list command (andinstallation getcommand) return the ClusterID, saving you from the second step.Ticket Link
https://mattermost.atlassian.net/browse/CLD-8669
Release Note