Use argocd to manage utilities for e2e-cluster #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
kind/feature
gabrieljackson
requested changes
Jul 12, 2024
nickmisasi
reviewed
Jul 12, 2024
e2e/tests/shared/shared.go
Outdated
|
|
||
| createClusterReq.DesiredUtilityVersions = map[string]*model.HelmUtilityVersion{ | ||
| model.NginxCanonicalName: { | ||
| Chart: "unmanaged", |
There was a problem hiding this comment.
Suggested change
| Chart: "unmanaged", | |
| Chart: model.UnmanagedUtilityVersion, |
This is also a constant we can use for all utilities.
gabrieljackson
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use argocd to manage utilities for e2e-cluster
Ticket Link
Fixes https://mattermost.atlassian.net/browse/CLD-7783
Release Note