Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upstream 67be473 #924

Merged
merged 8 commits into from
Feb 24, 2025
Merged

feat: Upstream 67be473 #924

merged 8 commits into from
Feb 24, 2025

Conversation

MBerguer
Copy link
Contributor

What 💻

Why ✋

  • To keep our codebase in sync with the upstream foundry

  • Check if these changes affect any documented features or workflows.

  • Update the book if these changes affect any documented features or workflows.

MBerguer and others added 4 commits February 17, 2025 19:37
@MBerguer @grandizzy
@jorgemmsilva @DaniPopes @zerosnacks @yash-atreya @mattsse @dwerner @leovct @github-actions @antazoey @JayWhite2357 @turbocrime @PanGan21
chore: Upstream 67be473 merge (#910)
ea30c75 
* chore: fix clippy (#9790)

* feat(anvil): implement `anvil_rollback` (#9783)

* implement anvil_rollback

* PR improvements

---------

Co-authored-by: grandizzy <[email protected]>

* docs(cast): clean up index docs (#9792)

* feat: add `gas_snapshot_check` flag to config, fix `FORGE_SNAPSHOT_CHECK` behavior (#9791)

* add gas_snapshot_check configuration option w/ FORGE_SNAPSHOT_CHECK, checking for bool value - not just existence

* add additional test to display behaviour

* improve docs

* fix clippy

* improve test suite, tests all combinations exhaustively

* fix failing test

* fix nit

* small nits

* feat(`forge`): remove `testFail*` (#9574)

* debt(`forge`): deprecate `testFail*`

* fix tests using testFail*

* fix

* refactor: expect revert failures tests to cli

* rm `testFail` from ExpectRevert.t.sol
Moved to ExpectRevertFailures.t.sol in cli tests

* mv ExpectCall.t.sol failure tests to ExpectCallFailures.t.sol in forge cli tests

* mv ExpectEmit.t.sol `testFail` to ExpectEmitFailures.t.sol as cli test

* mv MemSafety failure tests

* fmt

* mv DSStyleTest failling assertion to cli test

* failure_assertions

* failing setup test

* multiple aftertInvariants

* multiple setups

* emit diff anonymous

* Err out on `testFail

* fix: test_core

* fix

* fix: test_logs

* fix: test_fuzz

* fix: repro_7481

* fix: testShouldFailRevertNotOnImmediateNextCall, mv to failure_assertions

* fix + forge fmt

* clippy

* chore: update and document external tests (#9644)

* rm `should_fail` from runner and TestFunctionKind

* update, document and add additional external tests

* remove newly added morpho for now

* fix

---------

Co-authored-by: Yash Atreya <[email protected]>

* ignore solmate tests

* nit

* rm should_fail from run_unit_test & run_fuzz_test

* fix fmt

* fmt

* forge fmt

* fix

* rm

* fix tests

* fix: repro_7238

* fix tests

* forge fmt

* fix: repro tests

* bump snekmate ext test

* revert snekmate bump

* bump snekmate

* Revert "bump snekmate"

This reverts commit a9e7568c6a0fea1533ab1e128a69da16df78f3c3.

* ignore ERC4626VaultTest in snekmate

* remove solmate ext_test

---------

Co-authored-by: zerosnacks <[email protected]>
Co-authored-by: zerosnacks <[email protected]>
Co-authored-by: grandizzy <[email protected]>

* fix: use sequence for rollback (#9795)

* chore: ignore solady CI failure in win (#9797)

* fix(trace_filter): allow params to be object or array with len 1 (#9793)

fix(trace_filter): change params objects to deserialize only an array

* chore: point forge-std ext test to latest main (#9799)

chore: point forgestd ext to latest

* chore: generate release notes from latest stable (#9801)

* chore: update version numbers for `v1.0.0-rc` (#9802)

update version numbers for 1.0.0-rc

* feat(cast): update polygon testnet chain and add polygon zkevm chains (#9803)

* feat: add polygon-amoy chain and remove polygon-mumbai

* feat: add polygon zkevm mainnet and cardona testnet chains

* chore: ci release on rc tag (#9805)

* chore: update pull request template (#9804)

* chore(deps): weekly `cargo update` (#9809)

Locking 35 packages to latest compatible versions
    Updating alloy-chains v0.1.57 -> v0.1.58
   Unchanged alloy-consensus v0.9.2 (available: v0.11.0)
   Unchanged alloy-contract v0.9.2 (available: v0.11.0)
   Unchanged alloy-eips v0.9.2 (available: v0.11.0)
   Unchanged alloy-genesis v0.9.2 (available: v0.11.0)
   Unchanged alloy-json-rpc v0.9.2 (available: v0.11.0)
   Unchanged alloy-network v0.9.2 (available: v0.11.0)
   Unchanged alloy-node-bindings v0.9.2 (available: v0.11.0)
   Unchanged alloy-provider v0.9.2 (available: v0.11.0)
   Unchanged alloy-pubsub v0.9.2 (available: v0.11.0)
   Unchanged alloy-rpc-client v0.9.2 (available: v0.11.0)
   Unchanged alloy-rpc-types v0.9.2 (available: v0.11.0)
   Unchanged alloy-serde v0.9.2 (available: v0.11.0)
   Unchanged alloy-signer v0.9.2 (available: v0.11.0)
   Unchanged alloy-signer-aws v0.9.2 (available: v0.11.0)
   Unchanged alloy-signer-gcp v0.9.2 (available: v0.11.0)
   Unchanged alloy-signer-ledger v0.9.2 (available: v0.11.0)
   Unchanged alloy-signer-local v0.9.2 (available: v0.11.0)
   Unchanged alloy-signer-trezor v0.9.2 (available: v0.11.0)
   Unchanged alloy-transport v0.9.2 (available: v0.11.0)
   Unchanged alloy-transport-http v0.9.2 (available: v0.11.0)
   Unchanged alloy-transport-ipc v0.9.2 (available: v0.11.0)
   Unchanged alloy-transport-ws v0.9.2 (available: v0.11.0)
    Updating async-trait v0.1.85 -> v0.1.86
    Updating aws-sdk-kms v1.57.0 -> v1.58.0
    Updating aws-sdk-sso v1.56.0 -> v1.57.0
    Updating aws-sdk-ssooidc v1.57.1 -> v1.58.0
    Updating aws-sdk-sts v1.57.0 -> v1.58.0
   Unchanged axum v0.7.9 (available: v0.8.1)
   Unchanged backtrace v0.3.71 (available: v0.3.74)
    Updating bumpalo v3.16.0 -> v3.17.0
    Updating cc v1.2.10 -> v1.2.11
    Updating clap_complete v4.5.42 -> v4.5.44
    Updating dyn-clone v1.0.17 -> v1.0.18
   Unchanged foundry-fork-db v0.10.0 (available: v0.11.0)
   Unchanged gcloud-sdk v0.25.8 (available: v0.26.2)
      Adding getrandom v0.3.1
    Updating httparse v1.9.5 -> v1.10.0
    Updating hyper v1.5.2 -> v1.6.0
    Updating indicatif v0.17.9 -> v0.17.11
    Updating jiff v0.1.27 -> v0.1.28
    Updating mdbook v0.4.43 -> v0.4.44
    Updating miette v7.4.0 -> v7.5.0
    Updating miette-derive v7.4.0 -> v7.5.0
   Unchanged op-alloy-rpc-types v0.9.6 (available: v0.10.0)
    Removing phf_generator v0.10.0
    Removing phf_shared v0.10.0
   Unchanged proptest v1.5.0 (available: v1.6.0)
   Unchanged protobuf v3.3.0 (available: v3.7.1)
   Unchanged protobuf-support v3.3.0 (available: v3.7.1)
   Unchanged rand v0.8.5 (available: v0.9.0)
   Unchanged revm-inspectors v0.14.1 (available: v0.15.0)
    Updating rustls v0.23.21 -> v0.23.22
    Updating rustls-pki-types v1.10.1 -> v1.11.0
    Updating ryu v1.0.18 -> v1.0.19
    Updating serde_json v1.0.137 -> v1.0.138
    Removing siphasher v0.3.11
   Unchanged solang-parser v0.3.3 (available: v0.3.4)
    Updating string_cache v0.8.7 -> v0.8.8
    Updating string_cache_codegen v0.5.2 -> v0.5.3
    Updating svm-rs v0.5.10 -> v0.5.11
    Updating svm-rs-builds v0.5.10 -> v0.5.11
    Updating syn v2.0.96 -> v2.0.97
    Updating tempfile v3.15.0 -> v3.16.0
    Updating toml_edit v0.22.22 -> v0.22.23
    Updating unicode-ident v1.0.15 -> v1.0.16
   Unchanged vergen v8.3.2 (available: v9.0.4)
      Adding wasi v0.13.3+wasi-0.2.2
    Updating webpki-roots v0.26.7 -> v0.26.8
    Removing winnow v0.6.24
      Adding winnow v0.6.26
      Adding winnow v0.7.0
      Adding wit-bindgen-rt v0.33.0
note: to see how you depend on a package, run `cargo tree --invert --package <dep>@<ver>`

Co-authored-by: mattsse <[email protected]>

* chore: replace maili with op-alloy (#9810)

* chore(deps): bump alloy 0.11 (#9798)

* wip: bump alloy

* wip

* fix: unused fields

* fixes

* fmt

* chore: nextest config

* update tests

* update tests

* fix

---------

Co-authored-by: DaniPopes <[email protected]>

* chore(tests): bump forge-std version (#9808)

* chore: bump forge-std version used for tests

* Fix gas and bind test

---------

Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: grandizzy <[email protected]>

* test: misc test improvements (#9812)

* more opts

* ignore can_disable_block_gas_limit

* move selector tests to integration tests

* reduce sleep

* rm unnecessary test, already tested with openchain/4byte commands

* rm needless_return allows

* chore: clippy

* move gas_report_fuzz_invariant to integration

* chore: tweak coverage warnings (#9814)

* test: update config with a closure (#9813)

* chore: update ext integration tests (#9811)

* chore: update ext integration tests

* Snekmate requires unreleased vyper 4.1

* fix(forge): allow `forge init --template` to work with `--no-commit` (#9815)

fix: allow init from template not commit

Co-authored-by: antazoey <[email protected]>

* feat(invariant): on failures show original and current sequence len (#9816)

* fix(cast): try decoding custom errors when execution reverted in cast send (#9794)

* fix(cast): try decoding custom errors when gas estimation in cast send

* Changes after review: use serde_json::from_str, use itertools format

* Nits

* More nits

* chore: remove rustls/openssl features (#9824)

* chore: fix base gas limit test (#9826)

* fix: mark metis as different gas calc (#9834)

* feat: add mathjax support to forge doc mdbook config (#9829)

* fix(foundryup): install for user names with empty space (#9835)

* feat(invariant): generate failed call sequence as solidity (#9827)

* feat(invariant): generate failed call sequence as solidity

* Fix test, format

* Tests nits

* chore: bump compilers, fix #9788 (#9836)

* feat: add way to disable emitting of gas snapshots to disk (#9710)

* feat: gas snapshot emit config

* review change comment

---------

Co-authored-by: turbocrime <[email protected]>

* chore(deps): weekly `cargo update` (#9843)

Locking 38 packages to latest compatible versions
    Updating alloy-chains v0.1.58 -> v0.1.59
    Updating alloy-trie v0.7.8 -> v0.7.9
    Updating aurora-engine-modexp v1.1.0 -> v1.2.0
    Updating aws-config v1.5.15 -> v1.5.16
    Updating aws-runtime v1.5.4 -> v1.5.5
    Updating aws-sdk-kms v1.58.0 -> v1.59.0
    Updating aws-sdk-sso v1.57.0 -> v1.58.0
    Updating aws-sdk-ssooidc v1.58.0 -> v1.59.0
    Updating aws-sdk-sts v1.58.0 -> v1.59.0
    Updating aws-sigv4 v1.2.7 -> v1.2.8
    Updating aws-smithy-runtime v1.7.7 -> v1.7.8
    Updating aws-smithy-types v1.2.12 -> v1.2.13
    Updating aws-types v1.3.4 -> v1.3.5
   Unchanged axum v0.7.9 (available: v0.8.1)
   Unchanged backtrace v0.3.71 (available: v0.3.74)
    Updating bytes v1.9.0 -> v1.10.0
    Updating cc v1.2.11 -> v1.2.13
    Updating clap v4.5.27 -> v4.5.28
    Updating clap_derive v4.5.24 -> v4.5.28
    Updating comfy-table v7.1.3 -> v7.1.4
      Adding const_format v0.2.34
      Adding const_format_proc_macros v0.2.34
   Unchanged derive_more v1.0.0 (available: v2.0.1)
   Unchanged evmole v0.6.2 (available: v0.7.0)
    Updating gcloud-sdk v0.26.2 -> v0.26.3
    Updating jiff v0.1.28 -> v0.1.29
    Updating jsonwebtoken v9.3.0 -> v9.3.1
    Updating once_cell v1.20.2 -> v1.20.3
    Updating op-alloy-consensus v0.10.0 -> v0.10.2
    Updating op-alloy-rpc-types v0.10.0 -> v0.10.2
    Updating parity-scale-codec v3.6.12 -> v3.7.4
    Updating parity-scale-codec-derive v3.6.12 -> v3.7.4
    Updating pin-project v1.1.8 -> v1.1.9
    Updating pin-project-internal v1.1.8 -> v1.1.9
   Unchanged proptest v1.5.0 (available: v1.6.0)
   Unchanged protobuf v3.3.0 (available: v3.7.1)
   Unchanged protobuf-support v3.3.0 (available: v3.7.1)
   Unchanged rand v0.8.5 (available: v0.9.0)
    Updating rustc-hash v2.1.0 -> v2.1.1
    Updating scc v2.3.0 -> v2.3.3
    Updating sdd v3.0.5 -> v3.0.7
   Unchanged solang-parser v0.3.3 (available: v0.3.4)
   Unchanged strum v0.26.3 (available: v0.27.0)
    Updating toml v0.8.19 -> v0.8.20
    Updating uuid v1.12.1 -> v1.13.1
   Unchanged vergen v8.3.2 (available: v9.0.4)
    Updating wait-timeout v0.2.0 -> v0.2.1
    Updating which v7.0.1 -> v7.0.2
    Updating winnow v0.7.0 -> v0.7.1
note: to see how you depend on a package, run `cargo tree --invert --package <dep>@<ver>`

Co-authored-by: mattsse <[email protected]>

* feat(`forge fmt`): add watch mode (#9838)

* feat(forge): add watch mode to forge fmt

* keen fmt run sync

---------

Co-authored-by: grandizzy <[email protected]>
Co-authored-by: Jorge Silva <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: zerosnacks <[email protected]>
Co-authored-by: Yash Atreya <[email protected]>
Co-authored-by: zerosnacks <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Daniel N. Werner <[email protected]>
Co-authored-by: Léo Vincent <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mattsse <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: grandizzy <[email protected]>
Co-authored-by: antazoey <[email protected]>
Co-authored-by: antazoey <[email protected]>
Co-authored-by: Jay White <[email protected]>
Co-authored-by: the letter L <[email protected]>
Co-authored-by: turbocrime <[email protected]>
Co-authored-by: Panagiotis Ganelis <[email protected]>
@Jrigada
Merge branch 'main' into upstream-67be473
163f6f8
@MBerguer
Merge branch 'main' into upstream-67be473
94ca3d7
@MBerguer
chore: Upstream 67be473 build (#915)
714413f 
* almost there

* making it compile

* clippy

* more clippy suggestions

* merging main back to fix the keys

* fixing cargo lock

* fixing this version of alloy-chain

* test fixing after 1.0.0 removed testFail functonality

* small diff
@MBerguer MBerguer requested a review from a team as a code owner February 20, 2025 18:19
@Jrigada Jrigada merged commit ca9d1aa into main Feb 24, 2025
50 checks passed
@Jrigada Jrigada deleted the upstream-67be473 branch February 24, 2025 18:09
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBerguer @nbaztec @Jrigada