Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct FOUNDRY_BIN_URL and FOUNDRY_BIN_PATH #914

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thepluck
Copy link

@thepluck thepluck commented Feb 15, 2025

What πŸ’»

  • Correcting FOUNDRY_BIN_URL and FOUNDRY_BIN_PATH.

Why βœ‹

  • The update() function in the script install original foundryup instead of update foundryup-zksync.

Evidence πŸ“·

Documentation πŸ“š

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

@thepluck thepluck requested a review from a team as a code owner February 15, 2025 20:47
@thepluck thepluck changed the title Correcting FOUNDRY_BIN_URL and FOUNDRY_BIN_PATH fix: Correct FOUNDRY_BIN_URL and FOUNDRY_BIN_PATH Feb 15, 2025
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! :)

@thepluck
Copy link
Author

thepluck commented Feb 18, 2025

Thanks for spotting this! :)

No problem :D Hope you guys produce a new version with better performance, testing is extremely slow rn.

@Karrq
Copy link
Contributor

Karrq commented Feb 19, 2025

What kind of tests are you running exactly? We are aware of the general performance issue with EraVM, but unless you are running fuzz tests (or invariant tests) those shouldn't take significantly longer, please open an issue.

@thepluck
Copy link
Author

thepluck commented Feb 19, 2025

What kind of tests are you running exactly? We are aware of the general performance issue with EraVM, but unless you are running fuzz tests (or invariant tests) those shouldn't take significantly longer, please open an issue.

Those tests are fuzz tests, but there are only 26 of them with runs = 16 in foundry.toml and it takes ~ 2 hours to finish testing. Compared to the normal foundry, we run 200+ fuzz tests, it only takes about 1 hour to finish with version < 1.0, and under 30 minutes for 1.0. The project repo is private for now so I can not share more information about it. But anyway, you guys did good work bringing a tool that eliminates the need for Hardhat in foundry projects when building multi-chain Dapps. For anyone curious, I am building Kyber Earn that will live on ZkSync Era soon.

@Karrq
Copy link
Contributor

Karrq commented Feb 20, 2025

I see, yeah unfortunately not a lot we can do there other than recommending using a different profile with less fuzz runs for development and keep a higher number of fuzz runs in CI for added security.
Please feel free to open issues in the future if you encounter bugs or unexpected behaviour!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants