Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use existing deployment nonce during storage migration #895

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Feb 3, 2025

What 💻

  • Use deployment nonce from storage when translating during a EVM <> zkEVM migration, else use zero value.
  • Add appropriate debug logs that state inconsistencies may occur due to EVM <> zkEVM mapping.

Why ✋

  • We would erroneously override deployment nonce with the transaction nonce.

Evidence 📷

Tests pass

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

Notes 📝

@nbaztec nbaztec requested a review from a team as a code owner February 3, 2025 16:22
@nbaztec nbaztec requested a review from Karrq February 4, 2025 12:07
Karrq
Karrq previously approved these changes Feb 4, 2025
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, and I think we should keep the "fork mode" for our in-memory mode even tho we don't need it anymore

@nbaztec nbaztec merged commit 857d5d2 into main Feb 4, 2025
23 checks passed
@nbaztec nbaztec deleted the nish-fix-nonce-fork-migration branch February 4, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants