Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper filter sets for ci test runs #875

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

elfedy
Copy link
Contributor

@elfedy elfedy commented Jan 27, 2025

What 💻

  • Append zksync filter expressions to the upstream ones.
  • Add tests in zksync packages to the subset of zk tests.

Why ✋

  • Current filters don't do what we expect, seems that having different filter expressions are joined using or and not and. This broke the upstream test workflow partition including tests from different partitions into one another and including zk tests into the upstream partitions.
  • Some tests in zksync package were missing the zk prefix making them included on the upstream tests and excluded from the zksync tests.

Evidence 📷

  • No zk tests run in upstream workflows.
  • Tests on zksync packages are included in zk test workflow.
  • Upstream workflows each run the same tests as their counterpart in upstream.

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

@elfedy elfedy requested a review from a team as a code owner January 27, 2025 18:00
@elfedy elfedy marked this pull request as draft January 27, 2025 18:13
@elfedy elfedy marked this pull request as ready for review January 27, 2025 18:46
Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fedy

@elfedy elfedy merged commit 886ff8b into main Jan 27, 2025
23 checks passed
@elfedy elfedy deleted the elfedy-fix-ci-filters branch January 27, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants