Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cross for builds #860

Merged
merged 5 commits into from
Jan 23, 2025
Merged

fix: use cross for builds #860

merged 5 commits into from
Jan 23, 2025
+33 −33

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Jan 23, 2025 •
edited
Loading

What 💻

  • Use cross for builds.

Why ✋

  • Building static binaries does not work for aarch64 on linux as there's not native github hosted runner.

Evidence 📷

https://github.com/matter-labs/foundry-zksync/actions/runs/12931632743/job/36065983713?pr=860

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

@nbaztec nbaztec requested a review from a team as a code owner January 23, 2025 09:56
@Karrq Karrq added the do not merge 🛑 Do not merge this PR until label is removed label Jan 23, 2025
@nbaztec nbaztec force-pushed the nish-fix-aarch64-build branch from 3c06a76 to 5a7b194 Compare January 23, 2025 15:24
@nbaztec nbaztec changed the title fix: aarch64 build fix: use cross for builds Jan 23, 2025
@nbaztec nbaztec removed the do not merge 🛑 Do not merge this PR until label is removed label Jan 23, 2025
@nbaztec nbaztec merged commit 87e8c5e into main Jan 23, 2025
23 checks passed
@nbaztec nbaztec deleted the nish-fix-aarch64-build branch January 23, 2025 16:06
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
@nbaztec nbaztec mentioned this pull request Jan 23, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrigada Jrigada Jrigada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbaztec @Jrigada @Karrq