Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Respect priority fee and max fee per gas for broadcasting txs with scripts #841

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Respect priority fee and max fee per gas for broadcasting txs with scripts #841

wants to merge 6 commits into from
+199 −9

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Jan 15, 2025 •
edited
Loading

What 💻

  • Use priority fee and max fee per gas when users set it instead of overwriting it with the estimation

Why ✋

  • We should let the users hardcode their values just as Foundry does.

Evidence 📷

Added a new test retrieving the tx data and asserting over it. Test passes

Documentation 📚

Please ensure the following before submitting your PR:

  • [ x ] Check if these changes affect any documented features or workflows.
  • [ x ] Update the book if these changes affect any documented features or workflows.
    Book Update PR

@Jrigada Jrigada requested a review from a team as a code owner January 15, 2025 11:34
@Jrigada Jrigada changed the title Fix: Respect priority fee and max fee per gas for broadcasting txs with scripts fix: Respect priority fee and max fee per gas for broadcasting txs with scripts Jan 15, 2025
elfedy
elfedy reviewed Jan 15, 2025
View reviewed changes
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
crates/forge/tests/it/zk/gas.rs Outdated Show resolved Hide resolved
crates/forge/tests/it/zk/gas.rs Outdated Show resolved Hide resolved
crates/script/src/broadcast.rs Outdated Show resolved Hide resolved
crates/script/src/broadcast.rs Outdated Show resolved Hide resolved
crates/zksync/core/src/lib.rs Outdated Show resolved Hide resolved
crates/zksync/core/src/lib.rs Outdated Show resolved Hide resolved
crates/zksync/core/src/lib.rs Outdated Show resolved Hide resolved
elfedy
elfedy previously approved these changes Jan 15, 2025
View reviewed changes
crates/forge/tests/it/zk/gas.rs Show resolved Hide resolved
Jrigada and others added 3 commits January 20, 2025 13:45
@Jrigada @elfedy
feat: Add zk gas per pubdata flag (#845)
94e7dbb 
* Add zk gas per pubdata flag

* Update crates/cli/src/opts/build/zksync.rs

Co-authored-by: Federico Rodríguez <[email protected]>

* simplify approach

* Cargo fmt

* Put back new line

* Update crates/script/src/lib.rs

Co-authored-by: Federico Rodríguez <[email protected]>

---------

Co-authored-by: Federico Rodríguez <[email protected]>
@Jrigada
Fix variable name
f487529
@Jrigada
Merge branch 'main' into jrigada-pass-down-gas-values-for-script
8405645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfedy elfedy elfedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jrigada @elfedy