Skip to content

refactor: migrate node errors #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 65 commits into from
Apr 9, 2025
Merged

refactor: migrate node errors #615

merged 65 commits into from
Apr 9, 2025

Conversation

sayon
Copy link
Contributor

@sayon sayon commented Mar 14, 2025

What 💻

  • update zksync-error version
  • Migrate Node component errors to zksync-error

Why ✋

  • Part of an effort to harmonize failure handling and reporting

Evidence 📷

@sayon sayon requested a review from a team as a code owner March 14, 2025 19:29
@sayon sayon marked this pull request as draft March 14, 2025 19:30
@sayon sayon force-pushed the iz/migrate-errors-node branch from 4210938 to 3aa852a Compare March 17, 2025 11:47
@sayon sayon requested review from itegulov and dutterbutter March 17, 2025 19:16
@sayon
Copy link
Contributor Author

sayon commented Mar 17, 2025

I am not the best person to write possible causes/fixes sections in the documentation so please double check me there so that there is nothing obviously dumb there @itegulov @dutterbutter

@sayon
fix: temporary suppress big Err warnings
bf4450e 
To be reverted when zksync-error supports boxing fields
@sayon sayon force-pushed the iz/migrate-errors-node branch from 911e6b5 to bf4450e Compare March 17, 2025 19:19
@sayon sayon marked this pull request as ready for review March 17, 2025 19:22
@sayon sayon mentioned this pull request Mar 18, 2025
Closed
dutterbutter
dutterbutter reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick pass will need to review further

@dutterbutter dutterbutter added the needs review 👓 PR requires a review label Mar 18, 2025
@sayon sayon requested a review from itegulov April 2, 2025 22:39
@sayon sayon force-pushed the iz/migrate-errors-node branch from bc4de40 to a9eba09 Compare April 7, 2025 22:50
itegulov
itegulov reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less just a bunch of nits. Happy to merge this once they are resolved.

Good job and sorry for the excessive nitpicking

@sayon
Copy link
Contributor Author

sayon commented Apr 8, 2025

Need to merge matter-labs/zksync-error#32 and update zksync-error version prior to merging this PR.

@sayon
Copy link
Contributor Author

sayon commented Apr 9, 2025

Ready to merge after checks and if @itegulov approves

itegulov
itegulov approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright looks good, let's merge this

@sayon sayon enabled auto-merge (squash) April 9, 2025 10:46
@sayon sayon merged commit 5a3141a into main Apr 9, 2025
18 checks passed
@sayon sayon deleted the iz/migrate-errors-node branch April 9, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itegulov itegulov itegulov approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees

@sayon sayon

Labels
needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayon @itegulov @dutterbutter