Improve README.md #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update image size display, along with typo fix
|
Thanks for this! These look to be some good improvements to the documentation. I'll try to have a good look through it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt,
Thank you for your wonderful tool that's an unmissable checkpoint in writing a DMG/GBC emulator.
I've made this PR to add a new failure example that I've found easy to miss (misaligned footer text caused by SCX not being handled).
Then I complete the README.md by decomposing per layer the final image.
Screenshots have been made using my own emulator.
Feel free to give me some feedback.
PS As I'm not working on a GBC emulator yet, I may not be able to produce the same result for GBC.