Add tests for creating rooms with names and topics #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating rooms with avatars is under a proposal at the time of writing. Spec: matrix-org/matrix-spec-proposals#1326 Synapse: matrix-org/synapse#3417 Signed-off-by: Travis Ralston <[email protected]>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
The original spec proposal (matrix-org/matrix-spec-proposals#1326) has instead gone the route of deprecating the name and topic. The avatar test is not needed. Signed-off-by: Travis Ralston <[email protected]>
turt2live
changed the title
|
I've updated this to be just for creating rooms with names and topics. Although the proposal is to deprecate these parameters, it seems useful to test these functions while the fields still exist. A later PR should remove them in the event the spec completes the deprecation process. |
Signed-off-by: Travis Ralston <[email protected]>
turt2live
changed the title
|
As per matrix-org/synapse#3421 (review), I think the tests of guest_can_join are incorrect. |
These aren't a thing.
|
Have removed the tests - please take a look |
richvdh
requested changes
Aug 2, 2018
turt2live
changed the title
|
I think this now does the right thing - PTAL. I have heavily abused copy/paste for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: matrix-org/matrix-spec-proposals#1326