Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip room join until we run into a 403 Forbidden and peek into world_readable rooms #272

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Skip room join until we run into a 403 Forbidden and peek into world_readable rooms #272

wants to merge 4 commits into from

Commits on Jun 22, 2023

  1. Show world_readable rooms in the room directory 

    See #271 (comment)
    @MadLittleMods
    MadLittleMods committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2845ac7 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Start of retryFnIfNotJoined

    @MadLittleMods
    MadLittleMods committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    79a468b View commit details
    Browse the repository at this point in the history

  2. Make sure fetchRoomData throws 403 errors 

    Before, it would swallow all of the errors and just return empty data
which was fine but now we want it to retry fetching if we weren't in
the room yet so we need that 403 error being thrown signal.
    @MadLittleMods
    MadLittleMods committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    2c2ce3e View commit details
    Browse the repository at this point in the history

  3. Apply retryFnIfNotJoined to the rest of the endpoints

    @MadLittleMods
    MadLittleMods committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ae50a9f View commit details
    Browse the repository at this point in the history