-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing metric documentions #23105
Open
sgiehl
wants to merge
19
commits into
5.x-dev
Choose a base branch
from
dev-14303
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+859
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ef3c90
to
c23afee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Documentation
For issues related to in-app product help messages, or to the Matomo knowledge base.
c: Usability
For issues that let users achieve a defined goal more effectively or efficiently.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR significantly improves metric documentation by adding many missing entries and enhancing existing ones. Additionally, it introduces a major overhaul in how the metric glossary is generated.
Key Changes
Improved Metric Documentation
Revamped Metric Glossary Generation
Impact
These changes ensure that the glossary provides accurate and reliable metric definitions, reducing inconsistencies caused by report-specific variations.
Note
The changes are causing some test failures in submodule, which we need to resolve after review, but before merging.
fixes #17230
Review