-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves responsiveness of KPI widgets on new all websites dashboard #22837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @sgiehl, I think there are some funny widths where we may need to adjust the styling. I know people usually don't play with their browser widths like in the video below, but we should try to avoid situations where we have stacked tiles but the border is on the side as well as displaying a scrollbar as some margins are too big or tiles too wide for the given overall width. Do you reckon you can look at adjust those? Thanks!
Screen.Recording.2024-12-11.at.3.57.41.PM.mp4
plugins/MultiSites/vue/src/AllWebsitesDashboard/AllWebsitesDashboard.less
Outdated
Show resolved
Hide resolved
e69191b
to
1d86d29
Compare
Description:
KPI widgets previously were always displayed in one row. If there was to few space, it became scrollable.
Note: The layout approach is a bit more flexible than the original design. This had to be applied so it works also with different languages.
With this PR the KPI widgets will wrap into multiple rows. For tablet like screen sizes, there will now be two KPIs displayed per row.
For mobile like screen sizes only one KPI per row will be shown:
Review