Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves responsiveness of KPI widgets on new all websites dashboard #22837

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 10, 2024

Description:

KPI widgets previously were always displayed in one row. If there was to few space, it became scrollable.

Note: The layout approach is a bit more flexible than the original design. This had to be applied so it works also with different languages.

With this PR the KPI widgets will wrap into multiple rows. For tablet like screen sizes, there will now be two KPIs displayed per row.
image

For mobile like screen sizes only one KPI per row will be shown:
image

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Dec 10, 2024
@sgiehl sgiehl added this to the 5.3.0 milestone Dec 10, 2024
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @sgiehl, I think there are some funny widths where we may need to adjust the styling. I know people usually don't play with their browser widths like in the video below, but we should try to avoid situations where we have stacked tiles but the border is on the side as well as displaying a scrollbar as some margins are too big or tiles too wide for the given overall width. Do you reckon you can look at adjust those? Thanks!

Screen.Recording.2024-12-11.at.3.57.41.PM.mp4

@sgiehl sgiehl requested a review from a team December 11, 2024 10:28
@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 11, 2024
@sgiehl sgiehl force-pushed the dev-18266 branch 2 times, most recently from e69191b to 1d86d29 Compare December 13, 2024 17:30
@sgiehl sgiehl merged commit c7c1027 into 5.x-dev Dec 18, 2024
25 of 26 checks passed
@sgiehl sgiehl deleted the dev-18266 branch December 18, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants