Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use terminal width independent "ps" command #22835

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

mneudert
Copy link
Member

@mneudert mneudert commented Dec 9, 2024

Description:

The current process list lookup is using a ps invocation that depends on the clients terminal width.

Until #22487 is merged, archiving can run on the same host multiple times with overlapping period, e.g. archive both a day and the matching week.

This PR provides the intermediate step of fixing the invocation until we can remove it, to lower the chance of having overlapping periods being archived on the same host.

See also #22515.
Refs L3-798

Review

@mneudert mneudert added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Dec 9, 2024
@mneudert mneudert requested a review from a team December 9, 2024 14:48
@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2024

@mneudert Is this fix something we should include in final Matomo 5.2.0 release?

@michalkleiner
Copy link
Contributor

I think a fix like this is ok to be merged between rc1 and stable 5.2.0 without an additional rc2, the change is quite safe in my view.

From the ps manual:

w      Wide output.  Use this option twice for unlimited width.

@sgiehl sgiehl merged commit 20cfe2d into 5.x-dev Dec 10, 2024
23 of 26 checks passed
@sgiehl sgiehl deleted the width-independent-ps branch December 10, 2024 14:46
@sgiehl
Copy link
Member

sgiehl commented Dec 10, 2024

@mneudert @michalkleiner FYI: I've also applied the fix on next_release branch, so it will be included in 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review Stability For issues that make Matomo more stable and reliable to run for sys admins.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants