Make links underlined everywhere (#20940)

* globally underline links

* don't underline navigation items

* remove unneeded rule

* underline footer links as well

* fix some links on plugin management page

* fix no result message in site selector search

* don't underline tab headlines

* don't underline drop-down items

* don't underline create annotation link

* Underline links in visits log

* Correctly underline the visitor profile link

* underline datatable page navigation links

* Don't underline help icon in enriched headline

* Don't link headline for ecommerce report

* don't underline items in mobile menu

* don't underline close icon of feedback banner

* don'T underline section chooser in user country map

* improve link layout of details link if integrity check fails during update

* updates expected UI test files

* don't underline close button in comparisons

* don't underline skip icon in tour widget

* updates expected UI test files

* adjust table icons

* don't underline table action icons

* updates expected UI test files

* make related report links underlined

* plugin uninstall link should be underlined

* updates expected UI test files

* make links in overlay underlined

* underline links in datatable labels

* updates expected UI test files

* underline links in multisites table

* updates expected UI test files

* don't underline icons in links

* don't underline table action links on hover

* don'T underline update check message on hover

* couple of fixes for links with icons

* updates expected UI test files

* move whitespaces in links, so they are not underlined

* fix system summary links

* updates expected UI test files

* updates expected UI test files

* fix tests

* submodule updates

* updates expected UI test files

plugins/Annotations/stylesheets/annotations.less

@@ -82,6 +82,7 @@ span.annotation {
     padding: 3px 0 6px 0;
     display: inline-block;
     margin:0;
+    text-decoration: none;
 }
 
 .annotation-controls>a:hover {

plugins/CoreHome/stylesheets/coreHome.less

@@ -223,6 +223,7 @@ a.Piwik_Popover_Error_Back {
     .icon {
         width: 16px;
         display: inline-block;
+        margin-right: 4px;
     }
     .icon-user {
         font-size: 11px;

plugins/CoreHome/stylesheets/dataTable/_dataTable.less

@@ -148,6 +148,14 @@ table.dataTable td a {
   color: @theme-color-text-light;
 }
 
+table.dataTable td a span.value {
+  text-decoration: underline;
+
+  &:hover {
+    text-decoration: underline;
+  }
+}
+
 td.clean {
   background-color: @theme-color-background-base;
 }
@@ -314,6 +322,7 @@ table.dataTable td #urlLink {
   color: #184A83;
   cursor: pointer;
   visibility: hidden;
+  text-decoration: underline;
   &:hover {
     text-decoration: underline;
   }
@@ -335,6 +344,7 @@ table.dataTable td #urlLink {
     color: @theme-color-text;
     cursor: pointer;
     font-weight: normal;
+    text-decoration: underline;
 
     &:hover {
       text-decoration: underline;
@@ -398,6 +408,12 @@ table.dataTable td #urlLink {
 }
 
 .tableIcon {
+  text-decoration: none;
+
+  &:hover {
+    text-decoration: none;
+  }
+
   &.activeIcon {
     background-color: @theme-color-background-tinyContrast;
   }

plugins/CoreHome/stylesheets/dataTable/_entityTable.less

@@ -61,6 +61,11 @@ table.entityTable {
   border: 0;
   color: inherit !important;
   display: inline-block;
+
+  a&[class^="icon-"], a&[class*=" icon-"] {
+    text-decoration: none!important;
+  }
+
   &:hover {
     background-color: @theme-color-background-base !important;
     box-shadow: 0 1px 2px 0 rgba(0,0,0,0.16), 0 1px 5px 0 rgba(0,0,0,0.12);
@@ -101,7 +106,7 @@ table.entityTable {
     vertical-align: middle;
     -webkit-tap-highlight-color: transparent;
     &:hover {
-      text-decoration: underline;
+      text-decoration: none;
     }
   }
 

plugins/CoreHome/stylesheets/dataTable/_rowActions.less

@@ -17,6 +17,11 @@ table.dataTable .dataTableRowActions a {
   padding: 6px 4px 6px 0;
   margin: 0;
   width: auto!important;
+  text-decoration: none;
+
+  &:hover {
+    text-decoration: none;
+  }
 
   .rowActionIcon {
     font-size: 19px;

plugins/CoreHome/stylesheets/layout.less

@@ -78,6 +78,7 @@ nav {
 
   ul a {
     color: @theme-color-header-text;
+    text-decoration: none;
 
     &:hover {
       text-decoration: none;
@@ -198,6 +199,7 @@ nav {
 
       .menu-icon {
         padding-right: 13px;
+        display: inline;
       }
 
       > li {
@@ -374,6 +376,7 @@ nav {
       }
       .menu-icon {
         padding-right: 13px;
+        display: inline;
       }
     }
 

plugins/CoreHome/templates/getSystemSummary.twig

@@ -4,19 +4,19 @@
             <div class="systemSummaryItem {% if item.getKey %}{{ item.getKey }}{% endif %}">
                 {% if item.getIcon %}<span class="icon {{ item.getIcon }}"></span>{% endif %}
 
-                {% if item.getUrlParams -%}
+                {%- if item.getUrlParams -%}
                     <a href="{{ linkTo(item.getUrlParams) }}" class="itemLabel">
-                {% else -%}
+                {%- else -%}
                     <span class="itemLabel">
-                {% endif -%}
+                {%- endif -%}
 
-                {{ item.getLabel }}{% if item.getValue %}:{% endif %}
+                {{ item.getLabel }}{% if item.getValue %}: {% endif %}
 
-                {%- if item.getUrlParams %}
+                {%- if item.getUrlParams -%}
                     </a>
-                {%- else %}
+                {%- else -%}
                     </span>
-                {%- endif %}
+                {%- endif -%}
 
                 {% if item.getValue %}<span class="itemValue">{{ item.getValue }}</span>{% endif %}
             </div>

plugins/CoreHome/templates/quickLinks.twig

@@ -2,17 +2,15 @@
     {% if hasSitesAdmin %}
     <div class="quickLink">
         <span class="icon icon-open-source">&nbsp;</span>
-        <a href="{{ linkTo({'module': 'SitesManager', 'action': 'index', 'showaddsite': '1'}) }}" class="itemLabel">
-            {{ 'SitesManager_AddSite'|translate|e }}
-        </a>
+        <a href="{{ linkTo({'module': 'SitesManager', 'action': 'index', 'showaddsite': '1'}) }}"
+           class="itemLabel">{{ 'SitesManager_AddSite'|translate|e }}</a>
     </div>
     {% endif %}
     {% if hasUsersAdmin %}
     <div class="quickLink">
         <span class="icon icon-user-add">&nbsp;</span>
-        <a href="{{ linkTo({'module': 'UsersManager', 'action': 'index', 'showadduser': '1'}) }}" class="itemLabel">
-            {{ 'UsersManager_InviteNewUser'|translate|e }}
-        </a>
+        <a href="{{ linkTo({'module': 'UsersManager', 'action': 'index', 'showadduser': '1'}) }}"
+           class="itemLabel">{{ 'UsersManager_InviteNewUser'|translate|e }}</a>
     </div>
     {% endif %}
     <br />