Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for util/context.ts and fix coverage for asyncLoad #1212

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add tests for util/context.ts and fix coverage for asyncLoad #1212

wants to merge 2 commits into from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 5, 2025

This PR adds a Context-browser.test.ts file that tests the ts/util/context.ts file in a browser by including a fake window object, and a Context-node.test.ts to test ts/util/context.ts when used in node.

Also, two asyncLoad files are adjusted so that the coverage is properly computed.

@dpvc dpvc requested a review from zorkow February 5, 2025 18:37
@dpvc dpvc added this to the v4.0 milestone Feb 5, 2025
Base automatically changed from update-test-framework to develop February 25, 2025 20:55
zorkow
zorkow requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

@dpvc dpvc requested a review from zorkow February 27, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow Awaiting requested review from zorkow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow