Https feature #41
Open
Https feature #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathieutu I haven't tested out every load option. Willing to accept change requests |
|
Thanks a lot, I'll review it the weekend. However I don't know how to really test it, so can you please give me a process? (my ssl part is always handle by a nginx part on top of the server) |
|
the readme lists 4 different options for loading the ssl files. |
|
should be srv/cert/key.pem and cert.pem |
|
Hi, sorry for the delay, the last weeks where a bit busy. I'll try to review it soon. Thanks. |
|
It's ok take your time. I know what it feels to have no time for side projects 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a rich https server above everything.
includes some other fixes as well