Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3625
deprecated
namespaceUIQuery
model toExploration
Database
model toConnection
Server, Database, Role, UserDatabaseRoleMap
modelsIt does not implement actually using the new models in any RPC functions. I was trying to keep the changes as small as possible.
Technical details
I tried to keep this PR minimal, but it's a major overhaul. The updated diagram for the relevant models is:
Note that
Exploration
isn't included in this diagram because it's not wired in yet. Also, I had to add some redundant foreign keys from theUserDatabaseRoleMap
model:database
toDatabase
role
toRole
server
toServer
.These were necessitated by the way Django works. Basically, these were added since we want to be able to traverse those fields as related in python.
Also, the multicolumn foreign keys aren't visible in the service layer. They're just added as custom SQL migrations to enforce integrity.
Finally, all tests are currently passing, but no new tests are added. We'll add tests for actual functionality using these models as appropriate.
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin