Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial permissions remodel #3626

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Initial permissions remodel #3626

merged 10 commits into from
Jun 17, 2024

Conversation

mathemancer
Copy link
Contributor

Fixes #3625

  • Moves all old DB-object models to a deprecated namespace
  • Moves UIQuery model to Exploration
  • Moves old Database model to Connection
  • Adds new Server, Database, Role, UserDatabaseRoleMap models

It does not implement actually using the new models in any RPC functions. I was trying to keep the changes as small as possible.

Technical details

I tried to keep this PR minimal, but it's a major overhaul. The updated diagram for the relevant models is:

image

Note that Exploration isn't included in this diagram because it's not wired in yet. Also, I had to add some redundant foreign keys from the UserDatabaseRoleMap model:

  • from database to Database
  • from role to Role
  • from server to Server.

These were necessitated by the way Django works. Basically, these were added since we want to be able to traverse those fields as related in python.

Also, the multicolumn foreign keys aren't visible in the service layer. They're just added as custom SQL migrations to enforce integrity.

Finally, all tests are currently passing, but no new tests are added. We'll add tests for actual functionality using these models as appropriate.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Anish9901 Anish9901 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into develop with commit 2bf84ad Jun 17, 2024
36 checks passed
@Anish9901 Anish9901 deleted the permissions_remodel_new branch June 17, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new permissions models
2 participants