Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CellSelection data structure and store #3037

Merged
merged 104 commits into from
Jun 6, 2024
Merged

Refactor CellSelection data structure and store #3037

merged 104 commits into from
Jun 6, 2024

Commits on Jul 13, 2023

  1. Begin scaffolding new Selection data structure

    @seancolsen
    seancolsen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6c67004 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Upgrade iter-tools package

    @seancolsen
    seancolsen committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    be561de View commit details
    Browse the repository at this point in the history

  2. Fill in more logic within Selection scaffolding

    @seancolsen
    seancolsen committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    29aedab View commit details
    Browse the repository at this point in the history

  3. Improve some naming

    @seancolsen
    seancolsen committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8b5ccdc View commit details
    Browse the repository at this point in the history

  4. Rename classes to mark old code as deprecated

    @seancolsen
    seancolsen committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    66f4e63 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Begin integrating SheetSelection into TabularData

    @seancolsen
    seancolsen committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8157a8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    a2eda36 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b3dd122 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1f0fe62 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    16eaf92 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Some readability improvements

    @seancolsen
    seancolsen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    640eb9b View commit details
    Browse the repository at this point in the history

  2. Add intersect method to ImmutableSet

    @seancolsen
    seancolsen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    de875e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Refactor Series tests to use cases

    @seancolsen
    seancolsen committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    c64e12b View commit details
    Browse the repository at this point in the history

  2. Tiny readability improvement

    @seancolsen
    seancolsen committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    be749ba View commit details
    Browse the repository at this point in the history

  3. Implement SheetSelection.forNewPlane

    @seancolsen
    seancolsen committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    0476730 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Begin incorporating new Selection into table sheet

    @seancolsen
    seancolsen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    09cd219 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Show selection status in column header

    @seancolsen
    seancolsen committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    63ef9cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a69d20a View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Fix clipboard code to work with new selection code

    @seancolsen
    seancolsen committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    bc8b8fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    59e25fa View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Remove legacySelection from table inspector

    @seancolsen
    seancolsen committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cc61dc3 View commit details
    Browse the repository at this point in the history

  2. Modify util fn to handle non-rectangular selection

    @seancolsen
    seancolsen committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    dd7f242 View commit details
    Browse the repository at this point in the history

  3. Refactor ExtractColumnsModal to use new selection

    @seancolsen
    seancolsen committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    70927ff View commit details
    Browse the repository at this point in the history

  4. Deprecate selection within Data Explorer

    @seancolsen
    seancolsen committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9bc1e5e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Use new Selection code in data explorer cell tab

    @seancolsen
    seancolsen committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    aeae784 View commit details
    Browse the repository at this point in the history

  2. Use new Selection code in DE col tab and results

    @seancolsen
    seancolsen committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    efa0dcb View commit details
    Browse the repository at this point in the history

  3. Remove lots of dead code

    @seancolsen
    seancolsen committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    faabf47 View commit details
    Browse the repository at this point in the history

  4. Rename isSelectedInRange to isSelected

    @seancolsen
    seancolsen committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9a9dbd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    24b4521 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5117eb2 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f4cda69 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Handle movement keys

    @seancolsen
    seancolsen committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ab60ce1 View commit details
    Browse the repository at this point in the history

  2. Begin moving mouse handling logic

    @seancolsen
    seancolsen committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5e72917 View commit details
    Browse the repository at this point in the history

  3. Refactor sheet element attributes

    @seancolsen
    seancolsen committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c205410 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Use dedicated components for sheet cell types

    @seancolsen
    seancolsen committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    44dd519 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Add match utility function for TS pattern matching

    @seancolsen
    seancolsen committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f544866 View commit details
    Browse the repository at this point in the history

  2. Begin scaffolding to handle drag selection

    @seancolsen
    seancolsen committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e8e5e34 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Document match function

    @seancolsen
    seancolsen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4f2a253 View commit details
    Browse the repository at this point in the history

  2. Finish implementation of ofSheetCellRange method

    @seancolsen
    seancolsen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ab4aca0 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Lift isSelected prop way up 

    Move from being used in CellWrapper to being used in SheetDataCell.
    @seancolsen
    seancolsen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    4e83d8d View commit details
    Browse the repository at this point in the history

  2. Clean up CellMode component

    @seancolsen
    seancolsen committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    457513a View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Remove table-view deps from CellInspector code

    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    2608b22 View commit details
    Browse the repository at this point in the history

  2. Pass columnIdentifierKey via prop not import 

    This is necessary because the table page and Data Explorer use
different values (and types) here.
    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    ad9dd5e View commit details
    Browse the repository at this point in the history

  3. Use common CellInspector component within DE

    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    602e972 View commit details
    Browse the repository at this point in the history

  4. Pass selection into data explorer sheet

    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    63b6dd9 View commit details
    Browse the repository at this point in the history

  5. Re-enable copying data explorer cells

    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    af35b89 View commit details
    Browse the repository at this point in the history

  6. Reinstate row header selection in table page

    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    748134d View commit details
    Browse the repository at this point in the history

  7. Reinstate row header selection in data explorer

    @seancolsen
    seancolsen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    7fded1c View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Reinstate deleting records

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a2ee62d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1fb4616 View commit details
    Browse the repository at this point in the history

  3. Fix checkbox toggle on click

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    53b8317 View commit details
    Browse the repository at this point in the history

  4. Fix LinkedRecordCell launch on click

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c1fee48 View commit details
    Browse the repository at this point in the history

  5. Fix SingleSelectCell opening

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7bee2ed View commit details
    Browse the repository at this point in the history

  6. Implement shift+click to select range

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    16fdd63 View commit details
    Browse the repository at this point in the history

  7. Order a table's processed columns sooner

    @seancolsen
    seancolsen committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    610c138 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c123fda View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Clean up some dead code

    @seancolsen
    seancolsen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a8be26d View commit details
    Browse the repository at this point in the history

  2. Remove TODO code comment

    @seancolsen
    seancolsen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6c18123 View commit details
    Browse the repository at this point in the history

  3. Improve code comments

    @seancolsen
    seancolsen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0f8cf9d View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5e02d7e View commit details
    Browse the repository at this point in the history

  2. Fix positioning of new record message

    @seancolsen
    seancolsen committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    141d27c View commit details
    Browse the repository at this point in the history

  3. Only render row control cell for rows with records

    @seancolsen
    seancolsen committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e4f1ec5 View commit details
    Browse the repository at this point in the history

  4. Add new record row when clicking placeholder

    @seancolsen
    seancolsen committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    218c59b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Implement SheetSelectionStore

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    89adabb View commit details
    Browse the repository at this point in the history

  2. Fix some linting errors

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    26a8c51 View commit details
    Browse the repository at this point in the history

  3. Handle CellWrapper focus in pure CSS

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    10f0aa2 View commit details
    Browse the repository at this point in the history

  4. Improve cell focus behavior

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    bbd1e64 View commit details
    Browse the repository at this point in the history

  5. Fix mousedown event on cell input element

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    894065a View commit details
    Browse the repository at this point in the history

  6. Prevent column resize from altering selection

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8ccb0a6 View commit details
    Browse the repository at this point in the history

  7. Improve parsing/serialization of cellId values

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2dff73f View commit details
    Browse the repository at this point in the history

  8. Add placeholder row to Plane

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0938b65 View commit details
    Browse the repository at this point in the history

  9. Allow typing into placeholder cells

    @seancolsen
    seancolsen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2f9cc96 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Remove some dead code

    @seancolsen
    seancolsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    659c9e2 View commit details
    Browse the repository at this point in the history

  2. Hide column resize handles during cell selection

    @seancolsen
    seancolsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2f0843c View commit details
    Browse the repository at this point in the history

  3. Use default cursor everywhere in sheet during selection

    @seancolsen
    seancolsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d7f91d8 View commit details
    Browse the repository at this point in the history

  4. Fix drag to re-order columns

    @seancolsen
    seancolsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1557b55 View commit details
    Browse the repository at this point in the history

  5. Auto-activate inspector tabs based on selection

    @seancolsen
    seancolsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b6374d1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    75eb454 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    30b5e78 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Set active cell to first-clicked when drag-selecting

    @seancolsen
    seancolsen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a188a56 View commit details
    Browse the repository at this point in the history

  2. Don't show text selection cursor on row header cells

    @seancolsen
    seancolsen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f003fae View commit details
    Browse the repository at this point in the history

  3. Show row header selection bg in Data Explorer

    @seancolsen
    seancolsen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    832e175 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Fix reactivity regression with data explorer rows

    @seancolsen
    seancolsen committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    95a1702 View commit details
    Browse the repository at this point in the history

  2. Don't set dummy rows in records store during fetch

    @seancolsen
    seancolsen committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    97c51bc View commit details
    Browse the repository at this point in the history

  3. Improve code readability of fetch options

    @seancolsen
    seancolsen committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e0b5439 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Loosen coupling between cause/effect of selection and inspector-tab-s… 

    …witch
    @seancolsen
    seancolsen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0fe1df9 View commit details
    Browse the repository at this point in the history

  2. Fix activation of column tab when adding columns to exploration

    @seancolsen
    seancolsen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a2825a3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1fcb946 View commit details
    Browse the repository at this point in the history

  4. Activate and focus first data cell on table load

    @seancolsen
    seancolsen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6797efa View commit details
    Browse the repository at this point in the history

  5. Fix linting problems

    @seancolsen
    seancolsen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0317a26 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Improve logic within forNewPlane

    @seancolsen
    seancolsen committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    6325be5 View commit details
    Browse the repository at this point in the history

  2. Small comment cleanup

    @seancolsen
    seancolsen committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f4f4eeb View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Reorganize some code

    @seancolsen
    seancolsen committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    adf17b1 View commit details
    Browse the repository at this point in the history

  2. Show loading indicator cell skeletons in record selector

    @seancolsen
    seancolsen committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    aa211ac View commit details
    Browse the repository at this point in the history

  3. Ensure active cell falls within selected cells

    @seancolsen
    seancolsen committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    dfe5bfc View commit details
    Browse the repository at this point in the history

  4. Improve retention of active cell

    @seancolsen
    seancolsen committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8d33995 View commit details
    Browse the repository at this point in the history

  5. Remove dead code comments

    @seancolsen
    seancolsen committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6ee7724 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Fix failing tests

    @seancolsen
    seancolsen committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    274b505 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    28ae92e View commit details
    Browse the repository at this point in the history

  2. Auto-sort imports in some files 

    In preparation for git merge with develop to avoid merge conflicts
    @seancolsen
    seancolsen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c371a20 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into selection

    @seancolsen
    seancolsen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1798dd2 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'develop' into selection

    @pavish
    pavish committed May 27, 2024
    Configuration menu
    Copy the full SHA
    69b771e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'develop' into selection

    @pavish
    pavish committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fc3ba8f View commit details
    Browse the repository at this point in the history

  2. Fix regression: Table inspector tabs do not get highlighted based on … 

    …column/row selection
    @pavish
    pavish committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5489684 View commit details
    Browse the repository at this point in the history