Skip to content

Conversation

@GiovanniCanali
Copy link
Collaborator

Solving issue #382.

Tests on actual values and labels for each differential operator are added where missing. All operators are tested both on the whole set of input/output components, and on a representative subset.

@GiovanniCanali GiovanniCanali marked this pull request as ready for review November 22, 2024 18:05
@dario-coscia dario-coscia self-requested a review November 23, 2024 09:02
@dario-coscia dario-coscia added the pr-to-review Label for PR that are ready to been reviewed label Nov 23, 2024
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration! I added just commented on a minor change which needs to be addressed.

@dario-coscia dario-coscia added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels Nov 23, 2024
@GiovanniCanali
Copy link
Collaborator Author

@dario-coscia The required changes have been applied. Please, review the new commit and, if everything is up to standards, merge.

@ndem0 ndem0 added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Nov 25, 2024
@ndem0 ndem0 linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@dario-coscia dario-coscia merged commit 5e36d1b into mathLab:master Nov 25, 2024
16 checks passed
@dario-coscia dario-coscia deleted the op_tests branch November 25, 2024 16:16
dario-coscia pushed a commit that referenced this pull request Mar 12, 2025
* Adding tests for operators
dario-coscia pushed a commit that referenced this pull request Apr 17, 2025
* Adding tests for operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional tests for operators

3 participants