Fix '#[loca]' typo to '#[local]' in continuous_path.v#1950
Open
mvanhorn wants to merge 1 commit intomath-comp:masterfrom
Open
Fix '#[loca]' typo to '#[local]' in continuous_path.v#1950mvanhorn wants to merge 1 commit intomath-comp:masterfrom
mvanhorn wants to merge 1 commit intomath-comp:masterfrom
Conversation
The attribute on Lemma fphi_one was written as '#[loca]' instead of '#[local]', so unlike the neighboring fphi_zero and fphi_cts lemmas, fphi_one was not actually marked local. Fixes math-comp#1945.
Member
|
Thanks, I am responsible for the typo. Will merge as soon as the CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1945.
The attribute on
Lemma fphi_oneintheories/homotopy_theory/continuous_path.v:119was written as#[loca]instead of#[local]. The neighboringfphi_zeroandfphi_ctslemmas are both correctly marked#[local], so without this fixfphi_oneis the only one of the three that is not actually scoped to the section.