measurable types are not pointed by default any more#1949
Open
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
Open
measurable types are not pointed by default any more#1949affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
Conversation
Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
This was referenced Apr 24, 2026
pi8027
reviewed
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #796
fyi: @shinya-katsumata @CohenCyril
We would like this change to be reflected in master as soon as possible so as to be able to work
with the following definition:
Structure distr := Distr { mu :> T -> R ; _ : forall x, 0 <= mu x ; _ : summable [set: T] (EFin \o mu) ; _ : \int[@counting (discrete_measurable_space T) R]_x (mu x) <= 1 }.without requiring
Tto be apointedType, only achoiceType,to preserve the generality of
distrfrom theexperimental_realspackage@strub @lyonel2017 (just substituting
summableandpsumfrom theirMathComp-Analysis equivalent to use the library more easily).
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers